mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.
Date Tue, 17 May 2016 02:18:09 GMT


> On May 13, 2016, 8:37 p.m., Benjamin Mahler wrote:
> > src/tests/health_check_tests.cpp, line 1059
> > <https://reviews.apache.org/r/47089/diff/1/?file=1375628#file1375628line1059>
> >
> >     It looks like the clock needs to be paused before the task is launched? Otherwise
we may have too much time advance between launching the task and pausing the clock, no?

Hi, @bmhaler. I find the advance could not work in `mesos-health-check`, because it launched
in a separate process. So I removed it.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47089/#review133196
-----------------------------------------------------------


On May 17, 2016, 2:14 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47089/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 2:14 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Niklas Nielsen, Timothy Chen, and Jiang Yan
Xu.
> 
> 
> Bugs: MESOS-1653
>     https://issues.apache.org/jira/browse/MESOS-1653
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Waited for first statusUpdate before advance clock in GracePeriod test.
> 
> 
> Diffs
> -----
> 
>   src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 
> 
> Diff: https://reviews.apache.org/r/47089/diff/
> 
> 
> Testing
> -------
> 
> Test with
> 
> ```
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="HealthCheckTest.GracePeriod" --verbose
--gtest_break_on_failure --gtest_repeat=-1
> ```
> 
> more than 1500 iteractions in my slow machine.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message