mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.
Date Tue, 17 May 2016 16:46:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46307/
-----------------------------------------------------------

(Updated May 17, 2016, 4:46 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, Neil Conway, and
Timothy Chen.


Changes
-------

Address @bmahler's comments.


Bugs: MESOS-1802
    https://issues.apache.org/jira/browse/MESOS-1802


Repository: mesos


Description (updated)
-------

In HealthStatusChange test cases, we launch a task that toggles between
healthy and unhealthy, and will never be killed because no consecutive
health failures occur. We need to ignore subsequent status updates it
is possible to continue to receive status updates before we stop the
driver.


Diffs (updated)
-----

  src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 

Diff: https://reviews.apache.org/r/46307/diff/


Testing
-------

# I still could not reproduce the problem in old code after repeatedly tests. So seems no
way to verify whether my assumption is correct or not.


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message