mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Review Request 47481: Rewrote os::read() to be friendlier to reading binary data.
Date Tue, 17 May 2016 19:03:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47481/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and switched to 'mcypark'.


Bugs: MESOS-5398
    https://issues.apache.org/jira/browse/MESOS-5398


Repository: mesos


Description
-------

The previous read() implementation was based on calling getline() to
read in chunks of data from a file. This is fine for text-based files,
but is a little strange for binary files.

The new implementation reads in chunks of raw bytes in exponentially
increasing chunk sizes, and works well for both text files and binary
files alike.


Diffs
-----

  3rdparty/stout/include/stout/os/read.hpp e1e97c1bcb7493a734fc77721a83c230b1a23724 

Diff: https://reviews.apache.org/r/47481/diff/


Testing
-------


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message