mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 47481: Rewrote os::read() to be friendlier to reading binary data.
Date Tue, 17 May 2016 20:34:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47481/
-----------------------------------------------------------

(Updated May 17, 2016, 8:34 p.m.)


Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and switched to 'mcypark'.


Changes
-------

Changed the logic in the read() call to copy from a stack allocated buffer instead of writing
to the string directly. I usually don't like stack allocated buffers because of their potential
security implications when it comes to stack buffer overflows, but I took extra care here
to make sure there won't be any :).


Bugs: MESOS-5398
    https://issues.apache.org/jira/browse/MESOS-5398


Repository: mesos


Description
-------

The previous read() implementation was based on calling getline() to
read in chunks of data from a file. This is fine for text-based files,
but is a little strange for binary files.

The new implementation reads in chunks of raw bytes in exponentially
increasing chunk sizes, and works well for both text files and binary
files alike.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/read.hpp e1e97c1bcb7493a734fc77721a83c230b1a23724 

Diff: https://reviews.apache.org/r/47481/diff/


Testing (updated)
-------

make check -j


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message