mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 47474: Windows: Disabled signal handlers in logging.cpp.
Date Tue, 17 May 2016 21:15:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47474/#review133628
-----------------------------------------------------------



Patch looks great!

Reviews applied: [47473, 47474]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 17, 2016, 5:34 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47474/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 5:34 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Joris Van Remoortere, and Michael
Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Disabled signal handlers in logging.cpp.
> 
> 
> Diffs
> -----
> 
>   src/logging/logging.cpp 20d2f6341bd39fc5d056f1046d258d006fc602e4 
> 
> Diff: https://reviews.apache.org/r/47474/diff/
> 
> 
> Testing
> -------
> 
> Windows: build/run
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message