mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Deshi Xiao <xia...@gmail.com>
Subject Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.
Date Wed, 18 May 2016 07:58:57 GMT


> On 三月 30, 2016, 9:08 a.m., Adam B wrote:
> > src/tests/slave_tests.cpp, lines 3541-3545
> > <https://reviews.apache.org/r/45474/diff/3/?file=1318849#file1318849line3541>
> >
> >     Here you shutdown the slave and wait (you'll probably want to advance the clock
rather than wait for 90s) for the slave to be declared SLAVE_LOST. Once this occurs, the master
will no longer allow the slave to reregister with the same slaveId, and the slave will be
told to kill all running tasks. The slave will do so and then restart and register as a new
slaveId. 
> >     This is what is meant by the quote from the design doc: "Currently this can
only be handled by stopping / draining a mesos slave entirely (Killing all of its running
jobs), removing it from the cluster, then bringing it back up as a brand new slave."
> >     
> >     To truly observe this behavior, you should start a task on the slave before
you shut it down. Then you will see a TASK_LOST and the task will be killed.
> 
> Deshi Xiao wrote:
>     Thanks Adam, i will udpate the test case.

@Adam B
Here i have a confuse,need your guide. use test case to track the TASK_LOST in restart slave.
do we expect keep the slave_id is not outdate?


- Deshi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126066
-----------------------------------------------------------


On 三月 30, 2016, 8:13 a.m., Deshi Xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45474/
> -----------------------------------------------------------
> 
> (Updated 三月 30, 2016, 8:13 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, haosdent huang, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-1739
>     https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Phase 1
> Make SlaveInfo mutable throughout the stack, and allow for expansion of resources and
attributes only (Which allows testing to make sure it propagates to the allocator, shows up
in offers, etc). Ensure there is unified checking for incompatibilities in both the slave
and master (the slave should validate the config, the master should validate that all operations
the slave takes are legal).
> 
> it derived from another PR(https://reviews.apache.org/r/25525/)
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 
> 
> Diff: https://reviews.apache.org/r/45474/diff/
> 
> 
> Testing
> -------
> 
> make check on localhost
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message