mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 47610: Reverted adding libelf as a default dynamic library in stout.
Date Thu, 19 May 2016 22:40:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47610/#review134064
-----------------------------------------------------------



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos ReviewBot


On May 19, 2016, 6:08 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47610/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 6:08 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The libelf library is not a standard library installed on all Linux
> systems, and it is not a library required to build stout in
> general. It is only required for subsystems that happen to use the
> <stout/elf.hpp> header. As such, we should only require this
> dependency for those specific subsystems. If we ever decide to build
> something into stout that depends on libelf by default, we can
> revisit this issue then.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/configure.ac 52b4a05e9b27518144e4382d107c9c7834a41015 
> 
> Diff: https://reviews.apache.org/r/47610/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message