mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 47587: Created separate local data file to manage releases information.
Date Fri, 20 May 2016 03:27:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/#review134089
-----------------------------------------------------------



Looks like you need to rebase, so I made my comments anyway :)

I'm assuming the workflow for generating the website hasn't changed with the introduction
of erb files?


site/data/releases.yml (line 2)
<https://reviews.apache.org/r/47587/#comment198732>

    s/release/releasing/
    
    s/a item/an item/



site/data/releases.yml (line 4)
<https://reviews.apache.org/r/47587/#comment198733>

    s/publish/publishing/
    
    s/a item/an item/



site/data/releases.yml (line 74)
<https://reviews.apache.org/r/47587/#comment198734>

    not sure why you called this "items" instead of "versions" ?


- Vinod Kone


On May 19, 2016, 10:32 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47587/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 10:32 p.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim Anderegg, and
Vinod Kone.
> 
> 
> Bugs: MESOS-1495
>     https://issues.apache.org/jira/browse/MESOS-1495
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Created separate local data file to manage releases information.
> 
> 
> Diffs
> -----
> 
>   site/data/releases.yml PRE-CREATION 
>   site/source/downloads.html.erb PRE-CREATION 
>   site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
>   site/source/index.html.erb PRE-CREATION 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47587/diff/
> 
> 
> Testing
> -------
> 
> Test by re-generate the website in my local machine.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message