mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <>
Subject Re: Review Request 45961: Support sharing of resources through reference counting of resources.
Date Sun, 22 May 2016 07:11:25 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 22, 2016, 7:11 a.m.)

Review request for mesos and Jiang Yan Xu.


Updates to reflect share->shared, and renaming of other APIs in Resources class.
Share count now reflects actual reference count in usedResources, but presence (or absence)
of shared resources in offer, allocator and sorter.

Bugs: MESOS-4431

Repository: mesos

Description (updated)

Each shared resource is accouted via its share count. This count is
updated based on the resource operations (such as add and subtract)
in various scenarios such as task launch and terminate at multiple
modules such as master, allocator, sorter, etc.
Allow DESTROY for shared volumes only if share count is 0.
Since shared resources are available to multiple frameworks of the
same role simultaneously, we normalize it with a weight equivalent
to the number of frameworks to which this shared resource has been
allocated to in the sorter.

Diffs (updated)

  src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 
  src/common/resources_utils.cpp 8e881a09500b0966b577e514077460f724868a8d 
  src/master/allocator/mesos/hierarchical.cpp 8b7b3afb5770c617918ec4864faaf8d8a7a81ef2 
  src/master/allocator/sorter/drf/sorter.hpp 05d5205d29ad74e01e07c508d88b6f8371541513 
  src/master/allocator/sorter/drf/sorter.cpp 4306973277b9d32356eed31ceabac09fb2a03e6c 
  src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
  src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
  src/master/master.cpp 0c05938de3e4eaeea2187559e81559f85318fa73 
  src/master/validation.hpp f29f9753c75e5abc3402ed23381edcea26517ab3 
  src/master/validation.cpp f490b899758bdac9676a6f6939918efa6ac52781 
  src/tests/master_validation_tests.cpp ca4442aa1ef0087a7d058d1b3aa430a1dbc16960 
  src/tests/sorter_tests.cpp eb207a36c18198588cd8a98b3860a66c2ff7a641 
  src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a 



Tests successful.


Anindya Sinha

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message