mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 47671: Windows: Allowed `dynamic_cast` on an object being constructed.
Date Sun, 22 May 2016 08:08:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47671/#review134260
-----------------------------------------------------------



Patch looks great!

Reviews applied: [47473, 47492, 47486, 47474, 47489, 47442, 47671]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 22, 2016, 6:59 a.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47671/
> -----------------------------------------------------------
> 
> (Updated May 22, 2016, 6:59 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere,
and Michael Park.
> 
> 
> Bugs: MESOS-5428
>     https://issues.apache.org/jira/browse/MESOS-5428
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Allowed `dynamic_cast` on an object being constructed.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 5c7833ceaed556cc4ffb650996e918c1a542c5f0 
> 
> Diff: https://reviews.apache.org/r/47671/diff/
> 
> 
> Testing
> -------
> 
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message