mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Bydzovsky <byd...@gmail.com>
Subject Re: Review Request 46892: Postponed closing std streams of the docker task until after reaping.
Date Mon, 23 May 2016 08:13:47 GMT


> On Kvě. 17, 2016, 7:24 odp., Alexander Rukletsov wrote:
> > src/docker/executor.cpp, line 308
> > <https://reviews.apache.org/r/46892/diff/1/?file=1368337#file1368337line308>
> >
> >     `.await()` blocks the execution and synchronously wait for docker to terminate.
I'd expect that during this period the docker executor won't be responsive to anything, like
escalating kills. Moreover, I'd expect that `TASK_KILLING` won't be sent by the driver since
we are blocked in the callback.
> >     
> >     If I understand your intention correctly, you want to discard `run` only after
the container terminates. This is what `reaped()` callbakc is for: it is invoked when the
container terminates, i.e. `stop` has signaled.
> >     
> >     My only concern about discarding `run` in `reaped()` is for the case when docker
container is starting but has not yet started. I would like us to test this case.

Hmm, as I said, I have never ever written a single c++ line of code that would be used somewhere
in production (just some projects during my studies). I dont know the frameworks, I dont know
the mesos codebase, I don't know your developped "libraries", I don't know how to write tests
for this project. If you have better solution, please show me. Maybe you could also participate
in the changes... To be honest, after almost HALF YEAR since I reported it, of no visible
movement towards solving the issue, I'm getting really of this.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46892/#review133601
-----------------------------------------------------------


On Kvě. 17, 2016, 6:15 odp., Martin Bydzovsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46892/
> -----------------------------------------------------------
> 
> (Updated Kvě. 17, 2016, 6:15 odp.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4279
>     https://issues.apache.org/jira/browse/MESOS-4279
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7 
> 
> Diff: https://reviews.apache.org/r/46892/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Bydzovsky
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message