mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 47633: Checked if IPv6 module was loaded before disabling it.
Date Mon, 23 May 2016 09:19:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47633/#review134323
-----------------------------------------------------------



Patch looks great!

Reviews applied: [47633]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 23, 2016, 7:55 a.m., Zhengju Sha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47633/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 7:55 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-5381
>     https://issues.apache.org/jira/browse/MESOS-5381
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Checked if IPv6 module was loaded before disabling it.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp ad792def2bb3a1614d21ca28d858e400d2e3ede1

> 
> Diff: https://reviews.apache.org/r/47633/diff/
> 
> 
> Testing
> -------
> 
> Enniornment and steps:
> 1. Enable mesos-slave --isolation=network/port_mapping on CentOS7.2 with kernel version:
3.10.0-327.10.1.el7.x86_64
> 2. Create application on marathon framework with commands such as "echo hello" using
MesosContainerizer
> 3. Load IPv6 module by removing "ipv6.disable=1" of GRUB_CMDLINE_LINUX in /etc/default/grub
> 4. Disable IPv6 module by adding "ipv6.disable=1" of GRUB_CMDLINE_LINUX in /etc/default/grub
> 
> Now mesos can run both of the testcases successfully.
> 
> 
> Thanks,
> 
> Zhengju Sha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message