mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 46892: Postponed closing std streams of the docker task until after reaping.
Date Mon, 23 May 2016 20:59:30 GMT


> On May 17, 2016, 7:24 p.m., Alexander Rukletsov wrote:
> > src/docker/executor.cpp, line 358
> > <https://reviews.apache.org/r/46892/diff/1/?file=1368337#file1368337line358>
> >
> >     Why this change?
> 
> Martin Bydzovsky wrote:
>     Geeez, do I really have to repeat myself milion times? Without this change, the killed/finished
task - however you call it ( = ended task) - would end up in TASK_FAILED state = which is
obviously the biggest bullshit. And again (I'm saying this for like fifth time) - when you
GRACEFULLY STOP non-docker task - by sending sigterm from the driver - it ends in FINISHED
STATE (as i showed in the goddman video - has even anyone watched it?!) - not KILLED. So you
are purposing to create inconsistency between docker and non-docker executor. Should i rewrite
the non-docker executor too?? to synchronize it? I guess not.

I thought we agreed to fix it in a separate patch, no?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46892/#review133601
-----------------------------------------------------------


On May 17, 2016, 6:15 p.m., Martin Bydzovsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46892/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 6:15 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4279
>     https://issues.apache.org/jira/browse/MESOS-4279
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7 
> 
> Diff: https://reviews.apache.org/r/46892/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Bydzovsky
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message