mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 45377: Made "driver" as optional for DockerVolume.
Date Mon, 23 May 2016 22:22:46 GMT


> On 五月 23, 2016, 5:55 p.m., Jie Yu wrote:
> > include/mesos/mesos.proto, line 1627
> > <https://reviews.apache.org/r/45377/diff/10/?file=1377335#file1377335line1627>
> >
> >     Please do not change the tag number.

Can you please show more detail for why do not change the tag number? This feature is not
released, is it ok to change the number?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45377/#review134401
-----------------------------------------------------------


On 五月 10, 2016, 3:41 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45377/
> -----------------------------------------------------------
> 
> (Updated 五月 10, 2016, 3:41 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5354
>     https://issues.apache.org/jira/browse/MESOS-5354
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made "driver" as optional for DockerVolume.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 73d4bc0ec3f34033eddf04aa41893c1fc66933b3 
>   include/mesos/v1/mesos.proto 44b4f8a059f9dfdcbf02f0c30c1b859898c2e617 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 76d0fa183c9099584da6a4ee1e5d474b871310c3

> 
> Diff: https://reviews.apache.org/r/45377/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message