mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 47389: Stout: Added support for correct path delimiters in Windows.
Date Mon, 23 May 2016 23:49:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47389/#review134464
-----------------------------------------------------------




3rdparty/stout/include/stout/os/mkdir.hpp (line 51)
<https://reviews.apache.org/r/47389/#comment199287>

    this can just be `path = os::PATH_SEPARATOR;`



3rdparty/stout/include/stout/os/mkdir.hpp (line 60)
<https://reviews.apache.org/r/47389/#comment199289>

    This can just be `path += os::PATH_SEPARATOR;`



3rdparty/stout/include/stout/path.hpp (lines 20 - 21)
<https://reviews.apache.org/r/47389/#comment199276>

    alphabetize.



3rdparty/stout/include/stout/path.hpp (lines 32 - 34)
<https://reviews.apache.org/r/47389/#comment199277>

    `char_separator` -> `separator_`
    `string_separator` -> `separator`



3rdparty/stout/include/stout/path.hpp (line 34)
<https://reviews.apache.org/r/47389/#comment199279>

    this can be `stringify`.



3rdparty/stout/include/stout/path.hpp (line 81)
<https://reviews.apache.org/r/47389/#comment199278>

    Can remove the `For obvious reasons, this was not spelled out every time.`


- Joris Van Remoortere


On May 23, 2016, 5:03 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47389/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 5:03 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Added support for correct path delimiters in Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/constants.hpp 438840aaef189ef4fb457b856790efb3b6333a7d

>   3rdparty/stout/include/stout/os/mkdir.hpp e86dbfd2416fc2835ef7c6c55a20f00429f7b4c6

>   3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f 
> 
> Diff: https://reviews.apache.org/r/47389/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message