mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.
Date Tue, 24 May 2016 00:09:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47374/#review134476
-----------------------------------------------------------



Looks ok to me, but I'd love for @jieyu or @karya or @tillt to give it the final ShipIt, since
they have more experience with tests in the Makefile.


src/Makefile.am (lines 1937 - 1938)
<https://reviews.apache.org/r/47374/#comment199316>

    Why does libmesos_tests_la_SOURCES need to include qos_controllers code?



src/Makefile.am (lines 1991 - 1992)
<https://reviews.apache.org/r/47374/#comment199320>

    I guess all these `tests/*.cpp` aren't needed anymore because they're covered in `libmesos_tests_la_SOURCES`
which is also included in `mesos_tests_DEPENDENCIES` and `mesos_tests_LDADD`?


- Adam B


On May 23, 2016, 5:08 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47374/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 5:08 p.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, Kapil Arya, Jan Schlicht,
and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gives external projects easier access to the test helpers used in
> mesos tests.  
> 
> For example, a module writer may want to write a test like 
> `src/tests/oversubscription_tests.cpp`.  To build and link against 
> this library, the module writer would mimic the build flags for tests:
> ```
> my_module_CPPFLAGS =                   \
>   -I$(ZOOKEEPER)/include               \
>   -I$(ZOOKEEPER)/generated             \
>   -DSOURCE_DIR=\"$(abs_top_srcdir)\"   \
>   -DBUILD_DIR=\"$(abs_top_builddir)\"  \
>   ...
> ```
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
> 
> Diff: https://reviews.apache.org/r/47374/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message