mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Pravat <dpra...@outlook.com>
Subject Re: Review Request 47486: Windows: Escaped command line arguments.
Date Wed, 25 May 2016 00:38:42 GMT


> On May 24, 2016, 11:49 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/include/process/windows/subprocess.hpp, lines 134-138
> > <https://reviews.apache.org/r/47486/diff/2/?file=1388551#file1388551line134>
> >
> >     Can you explain why `strings::replace` doesn't work here? Why do we need to
manually implement it?

It will work.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47486/#review134664
-----------------------------------------------------------


On May 19, 2016, 11:07 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47486/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 11:07 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere,
and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The command line for the containerizer has the command encoded
> as JSON. Non escaped quotes are removed during the containerizer
> startup and the JSON processed is invalid.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/windows/subprocess.hpp 551770b9ec24b880c13441f413c5d1871fbf5c3a

> 
> Diff: https://reviews.apache.org/r/47486/diff/
> 
> 
> Testing
> -------
> 
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message