mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 47804: Fixed a memory leak in SchedulerProcess.decline
Date Wed, 25 May 2016 02:29:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47804/#review134683
-----------------------------------------------------------



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos ReviewBot


On May 25, 2016, 12:51 a.m., Dario Rexin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47804/
> -----------------------------------------------------------
> 
> (Updated May 25, 2016, 12:51 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/MESOS-5449
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-5449
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MesosScheduler.declineOffers has been changed ~6 months ago to send a Decline message
instead of calling acceptOffers with an empty list of task infos. The changed version of declineOffer
however did not remove the offerId from the savedOffers map, causing a memory leak.
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp 9e55885 
> 
> Diff: https://reviews.apache.org/r/47804/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dario Rexin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message