mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 47558: Added allower interface to authorizer.
Date Wed, 25 May 2016 03:03:54 GMT


> On May 24, 2016, 8:39 p.m., Alexander Rojas wrote:
> > src/authorizer/local/authorizer.cpp, line 116
> > <https://reviews.apache.org/r/47558/diff/6/?file=1390617#file1390617line116>
> >
> >     This method is reentrant and it doesn't depends on anything but its parameters,
so it would be better to make it `static` in the local authorizer and call that one instead
of copying paying the whole code.

already captured that implicitly in the mental comment above for allows.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47558/#review134631
-----------------------------------------------------------


On May 22, 2016, 9:25 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47558/
> -----------------------------------------------------------
> 
> (Updated May 22, 2016, 9:25 p.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Bugs: MESOS-5403
>     https://issues.apache.org/jira/browse/MESOS-5403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added allower interface to authorizer.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.hpp ed5f9e73661e25a83722cf1e408ae61023cd4a21 
>   src/authorizer/local/authorizer.hpp 61388454025211fd7d53e71a86983fd8479950b6 
>   src/authorizer/local/authorizer.cpp dc53bc4374aea98b5ed41ade5617374d2447229b 
>   src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
>   src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e 
> 
> Diff: https://reviews.apache.org/r/47558/diff/
> 
> 
> Testing
> -------
> 
> tested entire chain.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message