mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dario Rexin <dario.re...@me.com>
Subject Re: Review Request 47804: Fixed a memory leak in SchedulerProcess.decline.
Date Wed, 25 May 2016 04:09:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47804/
-----------------------------------------------------------

(Updated May 25, 2016, 4:09 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Fixed "Bugs", "People" and "Summary". -- @vinodkone


Summary (updated)
-----------------

Fixed a memory leak in SchedulerProcess.decline.


Bugs: MESOS-5449
    https://issues.apache.org/jira/browse/MESOS-5449


Repository: mesos


Description
-------

MesosScheduler.declineOffers has been changed ~6 months ago to send a
Decline message instead of calling acceptOffers with an empty list of
task infos. The changed version of declineOffer however did not remove
the offerId from the savedOffers map, causing a memory leak.


Diffs
-----

  src/sched/sched.cpp 9e55885 

Diff: https://reviews.apache.org/r/47804/diff/


Testing
-------

make check


Thanks,

Dario Rexin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message