mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 47711: Added more verbose message when mesos command encouter error.
Date Fri, 27 May 2016 04:58:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47711/#review135151
-----------------------------------------------------------




src/cli/mesos-cat (line 120)
<https://reviews.apache.org/r/47711/#comment200176>

    why did you pull this into a 'exception' variable? why not just do `fatal(Failed to get
the master: %s' % str(e))` ?
    
    here and everywhere else


- Vinod Kone


On May 23, 2016, 5:34 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47711/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 5:34 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5438
>     https://issues.apache.org/jira/browse/MESOS-5438
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added more verbose message when mesos command encouter error.
> This is mainly for adding exception info to error log
> when using to mesos-xx get state info.
> 
> 
> Diffs
> -----
> 
>   src/cli/mesos-cat ddc5a26d0a4618e9e032b4fcc75a230e49b7a2c5 
>   src/cli/mesos-scp f305abdc3bc0e4f357a5df90764a39ab55f46e86 
>   src/cli/mesos-tail 031ee251fde3b230c14d9ee0f0de68caa04d6595 
> 
> Diff: https://reviews.apache.org/r/47711/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message