mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48008: Added v1 protos for master and agent APIs.
Date Sat, 28 May 2016 23:13:05 GMT


> On May 28, 2016, 10:58 p.m., Kevin Klues wrote:
> > include/mesos/v1/agent.hpp, lines 35-36
> > <https://reviews.apache.org/r/48008/diff/2/?file=1400524#file1400524line35>
> >
> >     Why is this wrapped and the one aboove not? They are the same line length

it's not of the same length! this has Response::Type (longer string) as parameter whereas
the above one has Call::Type (shorter string) as parameter.


> On May 28, 2016, 10:58 p.m., Kevin Klues wrote:
> > include/mesos/v1/master.hpp, lines 35-36
> > <https://reviews.apache.org/r/48008/diff/2/?file=1400526#file1400526line35>
> >
> >     Same comment as above.

see above.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48008/#review135398
-----------------------------------------------------------


On May 28, 2016, 8:29 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48008/
> -----------------------------------------------------------
> 
> (Updated May 28, 2016, 8:29 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.
> 
> 
> Bugs: MESOS-2257 and MESOS-2720
>     https://issues.apache.org/jira/browse/MESOS-2257
>     https://issues.apache.org/jira/browse/MESOS-2720
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also added common protos to v1/mesos.proto.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.proto 555f51b621b21b87b8db00b9ea62cd911d229504 
>   include/mesos/v1/agent.hpp PRE-CREATION 
>   include/mesos/v1/agent.proto PRE-CREATION 
>   include/mesos/v1/master.hpp PRE-CREATION 
>   include/mesos/v1/master.proto PRE-CREATION 
>   include/mesos/v1/mesos.proto af95b5233158c68db356a4c178d9811cf7bf665d 
> 
> Diff: https://reviews.apache.org/r/48008/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message