mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 47990: Added move semantics to `Pipe::write()`.
Date Sun, 29 May 2016 04:46:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47990/#review135416
-----------------------------------------------------------



what's the reason for not having a rvalue ref overload?

- Vinod Kone


On May 27, 2016, 10:14 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47990/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 10:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of having separate rvalue overload for `write`,
> this change takes the sink argument by value
> and then does a move. This has the additional small
> overhead of performing an extra move.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 10f6fb90e436300bc47f4d5d2ad4beabd19026ba

>   3rdparty/libprocess/src/http.cpp b7839b1402d0660a2461085f5a1db191296e3308 
> 
> Diff: https://reviews.apache.org/r/47990/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message