mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48016: Implemented v1::master::Call::GET_VERSION.
Date Mon, 30 May 2016 01:24:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48016/
-----------------------------------------------------------

(Updated May 30, 2016, 1:24 a.m.)


Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.


Changes
-------

benm's comments. NNFR.


Bugs: MESOS-5479
    https://issues.apache.org/jira/browse/MESOS-5479


Repository: mesos


Description
-------

Refactored version/version.hpp a bit for this.


Diffs (updated)
-----

  src/internal/evolve.cpp e7afcdb629a509e8bb30ba29542f360066eb8ad4 
  src/master/http.cpp bbbf0a00e486b96e036f59a3107789d0322bc6cd 
  src/master/main.cpp 25c532c4932dce09c79e1b1c9e2aa4979835f67c 
  src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
  src/slave/main.cpp ecaa7826798e43244e69315cf0a64e486054cafb 
  src/tests/api_tests.cpp PRE-CREATION 
  src/version/version.hpp 7bcc66737f8332e72c529d93a885b2c027b8dd2a 
  src/version/version.cpp 4eb04230bf564160142f09f65282b60f5aec5eeb 

Diff: https://reviews.apache.org/r/48016/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message