mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 48029: Implemented v1::agent::Call::GET_LOGGING_LEVEL.
Date Mon, 30 May 2016 10:01:28 GMT


> On 五月 30, 2016, 8:50 a.m., Guangya Liu wrote:
> > @haosdent, are you missing the `validation` for both master and agent for GET_LOGGING_LEVEL?
https://github.com/apache/mesos/blob/master/src/master/validation.cpp#L87-L88
> 
> haosdent huang wrote:
>     Hi, @gyliu Thanks a lot for your review. Because we don't need pass parameter in
GET_LOGGING_LEVEL, I think it is not necessary to update there.

I see. Thanks @haosdent.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48029/#review135477
-----------------------------------------------------------


On 五月 30, 2016, 7:50 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48029/
> -----------------------------------------------------------
> 
> (Updated 五月 30, 2016, 7:50 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5512
>     https://issues.apache.org/jira/browse/MESOS-5512
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented v1::agent::Call::GET_LOGGING_LEVEL.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 407867be635b5ed4f7bbec1d82df4e3fa1ff6730 
>   src/slave/slave.hpp 19f95e40a2ca4c94449083de2455c4b2c4a5a77d 
>   src/tests/api_tests.cpp 83669431d6bcf45cbb6059c828fe5b7579fe2169 
> 
> Diff: https://reviews.apache.org/r/48029/diff/
> 
> 
> Testing
> -------
> 
> ./bin/mesos-tests.sh --gtest_filter="*GetLoggingLevel*" --verbose
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*GetLoggingLevel*" --verbose
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="*GetLoggingLevel*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message