mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bernd Mathiske <be...@mesosphere.io>
Subject Re: Review Request 48033: Fixed signed/unsigned comparison introduced in `f22af98`.
Date Mon, 30 May 2016 10:57:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48033/#review135493
-----------------------------------------------------------


Ship it!




This fixes the build and is in line with the prevalent style around here. (Long-term, follow-up
cleanup around everything glog-related might be a good idea.)

- Bernd Mathiske


On May 30, 2016, 3:23 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48033/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 3:23 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 1d7a3a9df395805c250148bf6232b00d712c7a05 
> 
> Diff: https://reviews.apache.org/r/48033/diff/
> 
> 
> Testing
> -------
> 
> Tested on various Linux configurations in internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message