mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.
Date Mon, 30 May 2016 15:19:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47123/
-----------------------------------------------------------

(Updated May 30, 2016, 11:19 a.m.)


Review request for mesos, Cody Maloney and Till Toenshoff.


Changes
-------

Addressed comments.


Bugs: MESOS-5173
    https://issues.apache.org/jira/browse/MESOS-5173


Repository: mesos


Description
-------

This allows the operator to use separate manifest JSON files for each
module.  Previously, one had to merge all module manifest files into a
single JSON file before passing on to the master/agent.


Diffs (updated)
-----

  3rdparty/libprocess/CMakeLists.txt 6312e20ec0102edbef086bf61ce4256109ae8fa0 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 22ae4acdb3ff695799a8c69fa7282b0c57e1b37a

  3rdparty/libprocess/configure.ac c8fcd35241c10829e7b2fa582491898589f0576f 
  3rdparty/libprocess/include/process/future.hpp 455b750430ae04d16f610c24c0ea0feb8a033708

  3rdparty/libprocess/include/process/http.hpp c180e6ebfbfc09e314eb6767e05cf22e546d977e 
  3rdparty/libprocess/include/process/io.hpp fed246bb96576b9aff247efedccc6af68b6dade3 
  3rdparty/libprocess/src/io.cpp d9c60754b1eaf83b1f5626a220f431cadeca541a 
  3rdparty/libprocess/src/tests/CMakeLists.txt 0c659dc00fe4fde78b2b57ebcc49cb47daf162d9 
  3rdparty/libprocess/src/tests/main.cpp a03dbc4ab46747003d8b11d22f2dc136293264ec 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 3f3e21514bd5e2e388165eb64d540764097557ac

  3rdparty/stout/configure.ac ada1e22c72875fe9d557f07e4846128be0bcef13 
  3rdparty/stout/include/Makefile.am 7f31582c176e653873402bd3f19b0c0195503d45 
  3rdparty/stout/include/stout/net.hpp 341d8ecea6f7e1244ad0027f110d6b0c69137667 
  3rdparty/stout/include/stout/os.hpp 53b00932693fba7cf6514da6a519269a904de345 
  3rdparty/stout/include/stout/os/access.hpp d87762a97152d55c58f6e54a9560c5fa0d051473 
  3rdparty/stout/include/stout/os/constants.hpp c71d52e1bc0433f9922f26a6eb486235bb9880d4 
  3rdparty/stout/include/stout/os/fsync.hpp bab337ed34f04111b12d266ba266a58b00c5e1ed 
  3rdparty/stout/include/stout/os/mkdir.hpp fe86864c8b480993c8f052f39b2fd3ece23798da 
  3rdparty/stout/include/stout/os/permissions.hpp 1fa7614878cb0f58270824c88ab0013a9d9f14e9

  3rdparty/stout/include/stout/os/posix/fork.hpp a906e4e03aac9ec9d95de62f905dcdbbba27c172

  3rdparty/stout/include/stout/os/posix/fsync.hpp 9a6bbf6c51b0a7d6085924733e33d8b4f1bbc1ac

  3rdparty/stout/include/stout/os/windows/fcntl.hpp 63533ab4bb5c439b9921bc4476bf13e3baa16ef4

  3rdparty/stout/include/stout/os/windows/fsync.hpp e1c4868b02b320906f446af1d9371374e90651bc

  3rdparty/stout/include/stout/os/windows/killtree.hpp 2be2f8c3d58ee64410f87ee4a4b2bb54fe014748

  3rdparty/stout/include/stout/os/windows/read.hpp cb0abf70307f0dbba0b8f68e884df199b0359186

  3rdparty/stout/include/stout/os/windows/stat.hpp e7f471b828d96bb5cd01823dd78c8570730712ea

  3rdparty/stout/include/stout/os/windows/write.hpp 705ad03ee58f9cc822ec1ed25fd10f39059717d4

  3rdparty/stout/include/stout/path.hpp 1b8326fd31562d82b6f17aa0945b9598184a9896 
  3rdparty/stout/include/stout/posix/net.hpp 39b89828d350d83bf1d4b0badcd3e63eb9d1a630 
  3rdparty/stout/include/stout/posix/os.hpp f08604cdd331f0f4394f64ec06a8461f1df6c888 
  3rdparty/stout/include/stout/protobuf.hpp 7bf704d2d0dee423c386c961d5fe72779ad51b5a 
  3rdparty/stout/include/stout/windows.hpp a71e2f4965c982331c2e8fe4be70027b373a6516 
  3rdparty/stout/include/stout/windows/net.hpp 1bed115cb848332bf9c31e455b2d001c173face9 
  3rdparty/stout/include/stout/windows/os.hpp 1363be1d4010028d4fc50242c80d91c0dd53e14c 
  CHANGELOG c778aeed24579d9c0ca880e7ebfa61a25f3cdd63 
  cmake/CompilationConfigure.cmake d3a5daee3c4c90712e920136bfe76fc9ab59ec45 
  docs/c++-style-guide.md a2e408f240611670fb2a72182b20fce9f0ebdcac 
  docs/cni.md cdc50da9db2f19f27be6a39f4d6e0f54834fb964 
  docs/committers.md e9f9dc520ab05e431051568bec9f6b8f19250960 
  docs/configuration.md edc6e26dd92e8577f05655ababfe8868ace80fca 
  docs/endpoints/index.md d22a56051b1335ef5097a8deea15efafbe5c2247 
  docs/endpoints/master/observe.md PRE-CREATION 
  docs/images/architecture-example.jpg e7a010c17779dc6c5cc0e785f3b0dac22da86b76 
  docs/images/architecture3.jpg aa82a4b42a23ab60dbea2c551df75e92fd375e24 
  docs/images/containerizer_isolator_api.png b84cd1dd082fc883b7f2b3b12458dc01e933d890 
  docs/images/ec_orphan_seqdiag.png 06de3a7324147333367a722e90c031d97a74150b 
  docs/images/ec_recover_seqdiag.png 08d4ca71a0c28bedc0436f5a01d9c506d1e32e54 
  docs/images/fetch_components.jpg 8d1ea9d395c4a586161508a78b59899cb41ea2ae 
  docs/images/networking-architecture.png 4e767d4d8a8b23c73918765483dc1a98e3534926 
  docs/images/oversubscription-overview.jpg 92ef297392910782a825dc1b3640b91d4dbe908c 
  docs/mesos-containerizer.md 1bd278392badcf34a305900491c1fd9b30c4420f 
  docs/multiple-disk.md 20b99e0e57360ad43804201b27e593d7ed48ce2c 
  docs/persistent-volume.md c70291ad2d58bacaf508dfd22d19c0f1a473d466 
  docs/powered-by-mesos.md ec02710b2c26b3d91e3b8ae4635c1cf01c881495 
  docs/release-guide.md dbe6d201d30081c304ea1ad4f750c04548790d6a 
  docs/reservation.md bbdaf8e3dad605e1fff8a7090865d6a772eb6c92 
  docs/sandbox.md db973e311b8562aa25fcdcdabefa1f342d25e26e 
  include/mesos/authorizer/acls.proto db55ee5be444aee8fc8871aa6cfdefc03a270401 
  include/mesos/authorizer/authorizer.proto 4478bbd3c8f5c1fb862c2c6bd450689d870f7059 
  include/mesos/docker/spec.hpp b37c7731590ec144df720d7b28eeed5db76f750e 
  include/mesos/docker/v1.proto 60d91d7aef5169b84322a6e0cb12bbef4011e1b7 
  include/mesos/hook.hpp c8a58641e0768628a9028a70d8c244448f7fb412 
  include/mesos/master/allocator.proto 8252abf47a19d5cc6c581c446b8756648fb2a054 
  include/mesos/mesos.proto dbffb16f4317df786ee38999a49e4e89733ff9ff 
  include/mesos/slave/isolator.hpp b90974e67ca69adfdc8198529d4ca8629da3dfca 
  include/mesos/type_utils.hpp 0d4dd2f0b1f03c51868247d978a41936cf3faf63 
  include/mesos/v1/agent.hpp 629e85226241fa49cfa321e2a68e2b8917491948 
  include/mesos/v1/agent.proto b9b1680afec4e73c31a9e0aeb74153d129c54ee6 
  include/mesos/v1/maintenance/maintenance.proto 053d72d7d9fa9ec8f572136020546fa4f955ab09

  include/mesos/v1/master.hpp b5bffa27e53ec84e25cd5f8046a581564076ebe8 
  include/mesos/v1/master.proto bcbdd4308ab1963289f59edc8c3cd7695afa72ab 
  include/mesos/v1/master/allocator.proto cf416d173bc487aecbbec75c9ee391a54bf5327b 
  include/mesos/v1/mesos.proto 39967fa09d2774d564f3df28277edea8ebcfb50d 
  include/mesos/v1/quota/quota.proto 424e6b4bf0064d146cfeeb19de77f0cce67882b9 
  site/.gitignore e180964fea36243da61f709d13054c6fff5ef70f 
  site/Dockerfile 80e28e96be53909a8c3c1eb3c05dbbc7e698a5a5 
  site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
  site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
  site/README.md 91bfd5fff16c7848431bdfc9206f42d18e102ace 
  site/Rakefile aa777bdd8e459f27ab487b5641595142f4e14c68 
  site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
  site/config.rb d43308b1082c64017980c6a37fb7c3be7b7265cf 
  site/data/releases.yml 0a3ba6ef5afbb3e0ba8eac8260fe63c9f4b31ebb 
  site/source/assets/css/main.css 8b897d2d91a1d2f4b3bed3cf1a5a1f97ebdc00ef 
  site/source/blog.html.erb 203c8696581d95ba1f7f04ab3de6656012ea65e9 
  site/source/community.html.md ea6e88534dbd86db9342f47dcc384f0a533ba39b 
  site/source/downloads.html.erb 3e24100a76a99b23ebc6589ee4f7332f43ef0ac9 
  site/source/downloads.html.md PRE-CREATION 
  site/source/index.html.erb 7d6357c863da18427c04309749688a6b3d20e69c 
  site/source/index.html.md PRE-CREATION 
  site/source/layouts/community_section.erb 698d19974b67ed1d1a221c941a68eb1f2c2e8233 
  site/source/layouts/documentation.erb a91f916a5fb7348b2702c272e7a2059bdf628c66 
  site/source/layouts/layout.erb c05b1a31c57e600916a62e447bb68a478afb1967 
  site/source/layouts/post.erb fdb566b01892d87fe6e121c958fe07b29cedf072 
  src/CMakeLists.txt 577a17c584923959fdd79bc53eb998a62e30b728 
  src/Makefile.am f083cd762d5a070836cb3198897399479b8548c7 
  src/authorizer/local/authorizer.cpp 547bbdd6c3605eadd23d2d2717a3fd362a616de5 
  src/cli/mesos-cat 778978e4e90e5a2d700699321868ad854e02e615 
  src/cli/mesos-ps 627795c41005003f0cb89f0ba3a888fce3a037cc 
  src/cli/mesos-scp a71ab07083465d734613227da7508fb55a258398 
  src/cli/mesos-tail 0d0fd6b8ebf619f6913928e69982eddf3c48c904 
  src/common/http.hpp 588a1eb18e2665e71cc4361835d873652c4e100d 
  src/common/http.cpp 27b5d4add218fdc90744407f39d8690b1c87e457 
  src/common/protobuf_utils.cpp 445e9d6dc637480b93943bd6d4aac5fc902bac26 
  src/common/type_utils.cpp 7110d87ba8078a5cc00669c82f8cd36f103c14b3 
  src/docker/docker.hpp d9ffc18496718701fac8182506a8c36e21e9c319 
  src/docker/executor.hpp d20a8fbbce57d4458e2162381e783f53d2c413fb 
  src/docker/executor.cpp f4796e4aa9951c30ada7feb44fb5d037895becce 
  src/docker/spec.cpp 7270d182b8c3a5d5c34cbda2bd736ba489089720 
  src/examples/long_lived_executor.cpp 770aae2fcc7a11db9abab31262cf81967796bb23 
  src/examples/persistent_volume_framework.cpp fe2837cfffb6dd251ccb9c93197f623d0c55fb36 
  src/examples/test_hook_module.cpp bc0bcb91eec0e2f666a76565b6cb3bb374f5b373 
  src/files/files.hpp a41c203349bac0f12ef574fceb201dd08dd957fc 
  src/files/files.cpp 074d31c116c1b9ff96262c3e0c776f38aea53d16 
  src/hook/manager.hpp 5ecfcab48da808c84d36f9bcfcb5a8e0ad2167e5 
  src/hook/manager.cpp 24885226a788a7abd851e12b527f74fa972ec935 
  src/internal/evolve.hpp 0fdda31bb2bdda46d23663379116fb7cc567055a 
  src/internal/evolve.cpp 4f25f1a892b4834fc4d79b6fd1bd0edd458b7a58 
  src/local/local.cpp c0c2766c9317b53a27eb50f6df1eb6ffd556a4cc 
  src/master/flags.hpp d08509667c919e9cfd076762b622c18732edf910 
  src/master/flags.cpp ceb4bd4f863d3857eede8287041a53d66f1c9e4c 
  src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616 
  src/master/main.cpp 871cf2d84eb13e429fe2d076cd7ce8d53c099944 
  src/master/master.hpp eeeccdfdfd296c2a484764e887564f2e065cfd14 
  src/master/master.cpp a6f740f7f71c4b54208e923025d32e0473a65f5e 
  src/master/validation.hpp 104263bdee244f7329049906da83c947f8443f33 
  src/master/validation.cpp 6550f296ae363788267c8cb9eaaf89ec6aceb00c 
  src/messages/messages.cpp 9274b1b3964a52a7929c2f1e9cea55e84b7549a1 
  src/messages/messages.proto 05e64769ec86718e972af47a199cc55add244d1b 
  src/module/manager.hpp 9944af0daf6c9cb5a8ff338099401b1db88ee237 
  src/module/manager.cpp 9f88ec3addab59e4a40b0b40612518178d535aa5 
  src/sched/flags.hpp b4ca12b667283cee1f96a4b421fcf3b06bbe59d7 
  src/sched/sched.cpp 8380e48950f9f9c7919cea6de5236cec8cc1729d 
  src/slave/containerizer/docker.hpp 311dca23ac17fb533866aba1de2b81d750bbe6df 
  src/slave/containerizer/docker.cpp 52caf9fe34b1a78efbec2a82d03c04a066690fad 
  src/slave/containerizer/mesos/containerizer.cpp b154587628a5bf4b1366dbd7a281177e6aa6eb57

  src/slave/containerizer/mesos/isolator.hpp b94947bc5e83b4f2a2174cb21ed559b4241d2c0a 
  src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp f290e3c1d1114698039a505e972793dc325c7100

  src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp 7849e518af448d9557ca4d6de4ccaba8bc572992

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b3fd8c85476bf46368bd79f052b7923ad9d32199

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 2665b022260b9228d4d34f030feb0d2f5de54bb3

  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 1de38491a33e5782b20e5ee491412779d09ee391

  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 31f35385691681ef5da14be747edfb5f57c5d05a

  src/slave/containerizer/mesos/isolators/docker/runtime.hpp 272636fcf12c865b31a11364f23d7aee9c6225db

  src/slave/containerizer/mesos/isolators/docker/runtime.cpp eb2790d44ee08c81d31fbe28e7a8ffe88edba870

  src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 842f2b5d4037e076cac4fd9c2eeb8f69786cffa7

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 2cc8e764ff18c95c29598df75cdb370ccf120662

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 8cebfebbd9bf3f616f3cd305889f3372aca5e3f3

  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 0afe9272900cfa4b39887eb259070a9a2df2ab93

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 0b406278808a15f3ea549839cc94f56909fa3571

  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 01ab1793d3d5469e6590617326b5e77e56bc7c50

  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp cb42d83a779c63c9ae25bbe72292aba3fe4cb8c9

  src/slave/containerizer/mesos/isolators/filesystem/shared.hpp 414682ba8380e8960ff93666799e2f0f674022c1

  src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 1846806831a46bb72d4ed5d2e136861301d8dd6a

  src/slave/containerizer/mesos/isolators/namespaces/pid.hpp 4e0dcd11067e0b05338f7c61e11840b7004ecbc9

  src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 368fac7b2e7cff24210b29c6f0769baeea983fbe

  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 09890cedf2e7a1846bd1cb250e117be1680a1b80

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp b9fcde44206f182ffff9ebad96dffd53609e2671

  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 15fff94de6998897ff8fc2d74ceb3fdbc1493445

  src/slave/containerizer/mesos/isolators/posix/disk.cpp 3dfe7ad4477dd1a6c8585bf761eaf435fd0cb366

  src/slave/containerizer/mesos/isolators/xfs/disk.hpp 52f0459421a45b01ce38b17c689633301cd97982

  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 19e55111edc0bf80a14fb7b2dade120b4432de53

  src/slave/containerizer/mesos/main.cpp 1a0e765ddb6d8519426b8d47067efdfa3432e07a 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp aaa0efe63e587b9e604082b52a3cb8c11545fbb9

  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb

  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 6456d90220a4026696a04f9969763cf682464353

  src/slave/containerizer/mesos/provisioner/docker/store.cpp cd5849bb9cdd12f2240885a0eae90569d2a9502e

  src/slave/containerizer/mesos/provisioner/provisioner.hpp 48a05059969e068a0ee0d38b61be9e7104e3188d

  src/slave/containerizer/mesos/provisioner/provisioner.cpp 9e803f6ae55f09f7e871c60531acce16ebd5e8fe

  src/slave/flags.hpp 3363412099ca2841e175bd6b6ed3d5f13605e6f0 
  src/slave/flags.cpp d30f39c216860c23e24d2d4064470c147c2824d2 
  src/slave/http.cpp 0b83f6dbd51f39380d75334e6e4cbe3211d04c44 
  src/slave/main.cpp f431e13703eafc003a1ffcbd0ee2247260e8708d 
  src/slave/slave.hpp 52aeb0d3727ce89ac792fc7e7a4b88ca01d15cdd 
  src/slave/slave.cpp c235c14814c320b4a8af8bf839ecced969de6e35 
  src/slave/validation.hpp 59b12f0109f6fa4c570f02d90834502a8edebe45 
  src/slave/validation.cpp 189d10caf4517a1aff62b523d8eb99d9d1ca4b6a 
  src/tests/api_tests.cpp 0b6bfadae3a969b3cd1a48e5095e64c953193543 
  src/tests/cluster.hpp 3b37f963400eaea9f7489d182ce024b43f7db874 
  src/tests/cluster.cpp f25b887d8a5b805e61640630f6f26f905f6c4f03 
  src/tests/common/http_tests.cpp 14a521b2564be5cdb52be51426fc359627aeeaf1 
  src/tests/containerizer/cni_isolator_tests.cpp b9fbd3890287c485f938fac2e778590d401a8244

  src/tests/containerizer/docker_containerizer_tests.cpp 5591a6784afd10b4c7535f90c2e6745fa74c318b

  src/tests/containerizer/docker_spec_tests.cpp 944a559bb3a8ef602b4d8d52773afdb8bf8e5bf6 
  src/tests/containerizer/filesystem_isolator_tests.cpp 30aab7671c963d7a93379988fbe8968ce05233d0

  src/tests/containerizer/memory_test_helper.cpp a8fdc1919c8c4fb2a9b6bb1cc2630669335e93c0

  src/tests/containerizer/provisioner_docker_tests.cpp ffe3382da8b1199e257a72ca9034fbccec9494b1

  src/tests/containerizer/runtime_isolator_tests.cpp c0c11607024b6a80d5bf5a486b91f7905a9083d7

  src/tests/containerizer/xfs_quota_tests.cpp 243ef33686059f3ef46f0c29cc59fa2a79d4ba5b 
  src/tests/disk_quota_tests.cpp 61ed464ed02c280b900c2e806a4c3fecc7444168 
  src/tests/dynamic_weights_tests.cpp 235495867f9da5ccddce496cd610a7d649e8a092 
  src/tests/files_tests.cpp 08f357b4c6138cfcad1fa01157922e0e5e3b12e1 
  src/tests/flags.hpp ae232b1a087edfaf678bd1c67bc509efd6c740d8 
  src/tests/hook_tests.cpp 36b64dfbfa3baf51605e33dfafa448c419a35d27 
  src/tests/main.cpp efec92286c78f7783e1de0781eb9e61c202a4fb8 
  src/tests/master_validation_tests.cpp 9eb82a569f7c48caa96d4d54a93b199ccac74385 
  src/tests/mesos.hpp 041cd42e2aaf5e57d7d575e5f4a97b71c01528b9 
  src/tests/persistent_volume_endpoints_tests.cpp 70b7626c8e87d1de59b13f9fd88fe9abb5f6b6a5

  src/tests/persistent_volume_tests.cpp 5125a8da44759d1235fddac26e9eb5436c3d037b 
  src/tests/repair_tests.cpp PRE-CREATION 
  src/tests/reservation_tests.cpp 2cc352d230f5ba8ca15698b09a44377c6af53913 
  src/tests/role_tests.cpp 162c9414a70723a212cfd39ac5c0b8325c3f3b5d 
  src/tests/slave_recovery_tests.cpp 2238355e9459cf4598a7aa96d3c6153a2dfcaa13 
  src/tests/slave_tests.cpp ab4633abf47f068032ee1d4a9b3cdd5428352c0a 
  src/version/version.hpp 1c86924ed5fbfb976877153915d87e8a76758497 
  src/version/version.cpp 11d948c702f38ab01b71d9cf106d61bc2b9e9554 
  src/webui/master/static/fonts/glyphicons-halflings-regular.eot b93a4953fff68df523aa7656497ee339d6026d64

  src/webui/master/static/fonts/glyphicons-halflings-regular.svg 94fb5490a2ed10b2c69a4a567a4fd2e4f706d841

  src/webui/master/static/fonts/glyphicons-halflings-regular.ttf 1413fc609ab6f21774de0cb7e01360095584f65b

  src/webui/master/static/fonts/glyphicons-halflings-regular.woff 9e612858f802245ddcbf59788a0db942224bab35

  src/webui/master/static/fonts/glyphicons-halflings-regular.woff2 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391

  src/webui/master/static/framework.html bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
  src/webui/master/static/frameworks.html cfb6f4efc259419e4cb697332c8d6f2839e96970 
  support/docker_build.sh 058b982d1a9ab5ac624d023fb1a1054128157083 
  support/site-docker/README.md PRE-CREATION 
  support/verify_reviews.py f14951b753ffbc1a939d1991d7bb901741efe388 

Diff: https://reviews.apache.org/r/47123/diff/


Testing
-------

Manual testing with:
1. --module_dir
2. --modules
3. --module_dir in conjunction with --modules

The first two succeeded while the third failed as expected.


Thanks,

Kapil Arya


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message