mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 48033: Fixed signed/unsigned comparison introduced in `f22af98`.
Date Mon, 30 May 2016 18:12:21 GMT


> On May 30, 2016, 7:46 p.m., Vinod Kone wrote:
> > src/tests/api_tests.cpp, line 180
> > <https://reviews.apache.org/r/48033/diff/1/?file=1400960#file1400960line180>
> >
> >     should we change the GetLoggingLevel::level to be int32 instead? not sure why
glog chose FLAGS_v to be signed.

We should definitely use the same types here, and using an unsigned type makes more sense
to me (the need to explicitly cast here is a dead give-away that the types need fixing).

Not sure glog why uses a signed value, could this be due to interop with representations which
need "unset" values (e.g., `-1`)?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48033/#review135530
-----------------------------------------------------------


On May 30, 2016, 12:23 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48033/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 12:23 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 1d7a3a9df395805c250148bf6232b00d712c7a05 
> 
> Diff: https://reviews.apache.org/r/48033/diff/
> 
> 
> Testing
> -------
> 
> Tested on various Linux configurations in internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message