mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.
Date Mon, 30 May 2016 19:03:10 GMT


> On May 30, 2016, 6:54 p.m., Anand Mazumdar wrote:
> > src/internal/evolve.hpp, lines 118-119
> > <https://reviews.apache.org/r/48049/diff/2/?file=1401315#file1401315line118>
> >
> >     This is not quite what I meant. My bad if my initial comment wasn't clear:
> >     
> >     I wanted an `evolve` function from `MasterInfo` to `v1::MasterInfo` and not
to `v1::master::Response` directly.
> >     
> >     We use evolve/devolve's to convert from unversioned message to versioned and
vice versa. There is currently no direct equivalent mapping from a unversioned message to
a Response. 
> >     
> >     You can then use the `evolve`'ed message to construct the `v1::master::Response`
in `getLeadingMaster`. Makes sense?

Yeah, Actually in other evolve, it is converted from object to response. That's why came the
misunderstanding.


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/#review135535
-----------------------------------------------------------


On May 30, 2016, 6:44 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48049/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5497
>     https://issues.apache.org/jira/browse/MESOS-5497
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented GET_LEADING_MASTER Call in v1 master API and
> made a minor change in the test case for GET_LOGGING_LEVEL.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp 0fdda31 
>   src/internal/evolve.cpp 4f25f1a 
>   src/master/http.cpp c8d2f46 
>   src/master/master.hpp eeeccdf 
>   src/tests/api_tests.cpp 0b6bfad 
> 
> Diff: https://reviews.apache.org/r/48049/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message