mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.
Date Mon, 30 May 2016 21:49:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/#review135550
-----------------------------------------------------------


Fix it, then Ship it!





src/master/http.cpp (lines 1203 - 1205)
<https://reviews.apache.org/r/48049/#comment200579>

    Nit: We try to have the `->` operator on the same line as the initial statement and
not use it as a continuation on subsequent lines.
    
    How about:
    
    ```cpp
    response.mutable_get_leading_master()->mutable_master_info()->CopyFrom(
        evolve(master->info()));
    ```


- Anand Mazumdar


On May 30, 2016, 9:01 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48049/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 9:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5497
>     https://issues.apache.org/jira/browse/MESOS-5497
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented GET_LEADING_MASTER Call in v1 master API and
> made a minor change in the test case for GET_LOGGING_LEVEL.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp 0fdda31 
>   src/internal/evolve.cpp 4f25f1a 
>   src/master/http.cpp c8d2f46 
>   src/master/master.hpp eeeccdf 
>   src/tests/api_tests.cpp 0b6bfad 
> 
> Diff: https://reviews.apache.org/r/48049/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message