mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 47805: Add authorization to GET /weights.
Date Tue, 31 May 2016 10:56:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47805/#review135615
-----------------------------------------------------------


Fix it, then Ship it!




Thanks for the update. Just a handful more nits, but I can fix these myself before committing.


docs/endpoints/master/weights.md (line 29)
<https://reviews.apache.org/r/47805/#comment200646>

    s/weights/weight/ to match the help.



src/master/weights_handler.cpp (line 68)
<https://reviews.apache.org/r/47805/#comment200645>

    We don't do const&'s for basic types like doubles/ints, since a pass-by-value copy
is just as efficient, and has no need for const.



src/master/weights_handler.cpp (line 84)
<https://reviews.apache.org/r/47805/#comment200648>

    s/authorizedRolesCollected/roleAuthorizationsCollected/



src/master/weights_handler.cpp (line 94)
<https://reviews.apache.org/r/47805/#comment200647>

    s/authorizedRoles/roleAuthorizations/



src/master/weights_handler.cpp (line 103)
<https://reviews.apache.org/r/47805/#comment200649>

    No need for const& with a bool either.



src/master/weights_handler.cpp (line 308)
<https://reviews.apache.org/r/47805/#comment200650>

    s/weights/weight/



src/master/weights_handler.cpp (line 309)
<https://reviews.apache.org/r/47805/#comment200651>

    We don't end log messages with punctuation.


- Adam B


On May 30, 2016, 7:05 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47805/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 7:05 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: mesos-5335
>     https://issues.apache.org/jira/browse/mesos-5335
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add 'GET_WEIGHTS_WITH_ROLE' for the authorization of GET /weights.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/master/weights.md 1e540795c5fb90c8ea957dd444b9e564e0b1ac23 
>   include/mesos/authorizer/acls.proto db55ee5be444aee8fc8871aa6cfdefc03a270401 
>   include/mesos/authorizer/authorizer.proto 4478bbd3c8f5c1fb862c2c6bd450689d870f7059

>   src/authorizer/local/authorizer.cpp 547bbdd6c3605eadd23d2d2717a3fd362a616de5 
>   src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616 
>   src/master/master.hpp eeeccdfdfd296c2a484764e887564f2e065cfd14 
>   src/master/weights_handler.cpp 4bc060fdb015df6658194eef92fe11b14aa15c79 
>   src/tests/dynamic_weights_tests.cpp 235495867f9da5ccddce496cd610a7d649e8a092 
> 
> Diff: https://reviews.apache.org/r/47805/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message