mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 48054: Added intergration tests for authorization based endpoint filtering.
Date Tue, 31 May 2016 21:15:03 GMT


> On May 31, 2016, 8:20 p.m., Vinod Kone wrote:
> > src/tests/master_authorization_tests.cpp, line 1273
> > <https://reviews.apache.org/r/48054/diff/2/?file=1402141#file1402141line1273>
> >
> >     instead of setting these "no principal can do foo" ACLs, you can just set permissive
to `false`.

when setting permissive to false I have to add a bunch of other acls (e.g. for registering
frameworks). So I would prefere to have one this acls explicitly disallowing the fact I want
to. Does that make sense?


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48054/#review135679
-----------------------------------------------------------


On May 31, 2016, 4:24 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48054/
> -----------------------------------------------------------
> 
> (Updated May 31, 2016, 4:24 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-5339
>     https://issues.apache.org/jira/browse/MESOS-5339
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added intergration tests for authorization based endpoint filtering.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_authorization_tests.cpp 5c221f059585d49bcccce5848bc0b655adab6b02 
> 
> Diff: https://reviews.apache.org/r/48054/diff/
> 
> 
> Testing
> -------
> 
> make check (OSx)
> + 100x repeat on new tests.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message