mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 46759: Updated Master to deal with Accept Offer vs InverseOffer correctly.
Date Tue, 31 May 2016 22:32:32 GMT


> On April 28, 2016, 7:24 p.m., Vinod Kone wrote:
> > src/master/metrics.cpp, line 227
> > <https://reviews.apache.org/r/46759/diff/1/?file=1364255#file1364255line227>
> >
> >     hmm...there is no "messages_accept_offers"? also, these are not really messages
but calls. see discussion in https://reviews.apache.org/r/44255/

I removed these metrics so we can step back and think about how we want to add them to be
consistent.


> On April 28, 2016, 7:24 p.m., Vinod Kone wrote:
> > src/master/validation.cpp, line 686
> > <https://reviews.apache.org/r/46759/diff/1/?file=1364257#file1364257line686>
> >
> >     Can we add tests for these validators? Or are these already implicitly tested?

I will file a JIRA to cover the validation logic with tests. There don't seem to be explicit
tests for the validation logic.


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46759/#review130976
-----------------------------------------------------------


On April 28, 2016, 1:22 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46759/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 1:22 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joseph Wu, and Vinod Kone.
> 
> 
> Bugs: MESOS-5296
>     https://issues.apache.org/jira/browse/MESOS-5296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated Master to deal with Accept Offer vs InverseOffer correctly.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/master/master.cpp ff41da3d077b65b44277e1bbae88c61b7bb88a3d 
>   src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 
>   src/master/metrics.cpp 88a752dc2b4b73ccb919e99478b9ea2bd83842a0 
>   src/master/validation.hpp 7fa1b892c1aff7453658c31e534dc272d1759b17 
>   src/master/validation.cpp f458100d22ec1f9f10921c1c91b6931a5671e28f 
> 
> Diff: https://reviews.apache.org/r/46759/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message