mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.
Date Mon, 23 May 2016 18:09:22 GMT
Can you also link the issue back to the review in JIRA:

Workflow -> Post Review

https://issues.apache.org/jira/browse/MESOS-5436

On Mon, May 23, 2016 at 11:02 AM, haosdent huang <haosdent@gmail.com> wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47719/
>
> On May 23rd, 2016, 5:29 p.m. UTC, *Kevin Klues* wrote:
>
> Looks good.  Just curous -- how did you upload the pictures to the testing section? 
Is there someway to make them smaller next time?
>
> LoL I upload it via jira and use ![](image_link) to show it in reviewboard. Seems reviewboard
don't allow specify the image width and height, I would resize them before upload next time.
;-)
>
>
> - haosdent
>
> On May 23rd, 2016, 4:56 p.m. UTC, haosdent huang wrote:
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Vinod Kone.
> By haosdent huang.
>
> *Updated May 23, 2016, 4:56 p.m.*
> *Bugs: * MESOS-5157 <https://issues.apache.org/jira/browse/MESOS-5157>
> *Repository: * mesos
> Description
>
> Removed invalid gpu statistics columns in framework data tables.
>
> Testing
>
> For apgent framework page:Before:
>
> After:
>
> For agent page:Before:
>
> After:
>
> Diffs
>
>    - src/webui/master/static/agent.html
>    (2f40034cf89e5f92ace3043578881b7b7157e25f)
>    - src/webui/master/static/agent_framework.html
>    (4d61c144ffbc51b9855e4b9f9cd99c0bbb1d35a5)
>
> View Diff <https://reviews.apache.org/r/47719/diff/>
>



-- 
~Kevin

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message