From reviews-return-34542-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sun May 22 07:09:52 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EAE8D18E7A for ; Sun, 22 May 2016 07:09:51 +0000 (UTC) Received: (qmail 30559 invoked by uid 500); 22 May 2016 07:09:51 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 30526 invoked by uid 500); 22 May 2016 07:09:51 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 30511 invoked by uid 99); 22 May 2016 07:09:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 May 2016 07:09:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 24B021D22AE; Sun, 22 May 2016 07:09:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2334925328928045443==" MIME-Version: 1.0 Subject: Re: Review Request 45960: Added interfaces to handle and track shareable resources. From: Anindya Sinha To: Jiang Yan Xu Cc: Anindya Sinha , Guangya Liu , mesos Date: Sun, 22 May 2016 07:09:51 -0000 Message-ID: <20160522070951.21614.90585@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Anindya Sinha X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45960/ X-Sender: Anindya Sinha References: <20160516182439.8624.30628@reviews.apache.org> In-Reply-To: <20160516182439.8624.30628@reviews.apache.org> Reply-To: Anindya Sinha X-ReviewRequest-Repository: mesos --===============2334925328928045443== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On May 16, 2016, 6:24 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 346 > > > > > > s/nonShareable/nonshared/. Renamed nonShareable() to nonShared(). - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45960/#review131462 ----------------------------------------------------------- On May 22, 2016, 7:09 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45960/ > ----------------------------------------------------------- > > (Updated May 22, 2016, 7:09 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-4431 > https://issues.apache.org/jira/browse/MESOS-4431 > > > Repository: mesos > > > Description > ------- > > Added interfaces to handle and track shareable resources. > > > Diffs > ----- > > include/mesos/resources.hpp a557e97c65194d4aad879fb88d8edefd1c95b8d8 > include/mesos/v1/resources.hpp a5ba8fec4c9c3643646308f75a4b28cefe0b3df3 > src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 > src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a > > Diff: https://reviews.apache.org/r/45960/diff/ > > > Testing > ------- > > Tests successful. > > > Thanks, > > Anindya Sinha > > --===============2334925328928045443==--