mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48101: Changed the ObjectApprover interface for optional subject and objects.
Date Wed, 01 Jun 2016 00:08:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48101/#review135729
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On May 31, 2016, 11:28 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48101/
> -----------------------------------------------------------
> 
> (Updated May 31, 2016, 11:28 p.m.)
> 
> 
> Review request for mesos, Adam B, Michael Park, Till Toenshoff, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Review 47505  changed the Request.object and subject to become optional
> fields.This patch adapts the ObjectApprover interface to deal with this
>  behavior.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.hpp ed5f9e73661e25a83722cf1e408ae61023cd4a21 
>   src/authorizer/local/authorizer.hpp 61388454025211fd7d53e71a86983fd8479950b6 
>   src/authorizer/local/authorizer.cpp 547bbdd6c3605eadd23d2d2717a3fd362a616de5 
>   src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616 
>   src/tests/master_authorization_tests.cpp 5c221f059585d49bcccce5848bc0b655adab6b02 
>   src/tests/mesos.hpp 041cd42e2aaf5e57d7d575e5f4a97b71c01528b9 
>   src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e 
> 
> Diff: https://reviews.apache.org/r/48101/diff/
> 
> 
> Testing
> -------
> 
> make check OSx
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message