mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 48054: Added intergration tests for authorization based endpoint filtering.
Date Wed, 01 Jun 2016 00:51:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48054/#review135730
-----------------------------------------------------------


Ship it!




Submitted with the following style changes.


src/tests/master_authorization_tests.cpp (line 1185)
<https://reviews.apache.org/r/48054/#comment200780>

    ```c++
    -    EXPECT_EQ(1u, stateSummary.values["frameworks"].as<JSON::Array>()
    -      .values.size());
    +    EXPECT_EQ(
    +        1u, stateSummary.values["frameworks"].as<JSON::Array>().values.size());
    ```



src/tests/master_authorization_tests.cpp (line 1200)
<https://reviews.apache.org/r/48054/#comment200781>

    ```c++
    -    Try<JSON::Object> parse  = JSON::parse<JSON::Object>(response.get().body);
    +    Try<JSON::Object> parse = JSON::parse<JSON::Object>(response.get().body);
    ```



src/tests/master_authorization_tests.cpp (line 1206)
<https://reviews.apache.org/r/48054/#comment200782>

    ```c++
    -    EXPECT_TRUE(stateSummary.values["frameworks"].as<JSON::Array>()
    -      .values.empty());
    +    EXPECT_TRUE(
    +        stateSummary.values["frameworks"].as<JSON::Array>().values.empty());
    ```



src/tests/master_authorization_tests.cpp (lines 1296 - 1298)
<https://reviews.apache.org/r/48054/#comment200783>

    ```c++
    -  Try<Owned<cluster::Slave>> slave = this->StartSlave(
    -      detector.get(),
    -      &containerizer);
    +  Try<Owned<cluster::Slave>> slave =
    +    this->StartSlave(detector.get(), &containerizer);
    ```



src/tests/master_authorization_tests.cpp (line 1314)
<https://reviews.apache.org/r/48054/#comment200784>

    ```c++
    -  Future<vector<Offer> > offers;
    +  Future<vector<Offer>> offers;
    ```



src/tests/master_authorization_tests.cpp (lines 1367 - 1369)
<https://reviews.apache.org/r/48054/#comment200785>

    ```c++
    -    JSON::Array frameworks =
    -      state.values["frameworks"].as<JSON::Array>();
    +    JSON::Array frameworks = state.values["frameworks"].as<JSON::Array>();
    ```



src/tests/master_authorization_tests.cpp (lines 1371 - 1372)
<https://reviews.apache.org/r/48054/#comment200786>

    ```c++
    -    JSON::Object framework =
    -      frameworks.values.front().as<JSON::Object>();
    +    JSON::Object framework = frameworks.values.front().as<JSON::Object>();
    ```



src/tests/master_authorization_tests.cpp (line 1388)
<https://reviews.apache.org/r/48054/#comment200787>

    ```c++
    -    Try<JSON::Object> parse  = JSON::parse<JSON::Object>(response.get().body);
    +    Try<JSON::Object> parse = JSON::parse<JSON::Object>(response.get().body);
    ```



src/tests/master_authorization_tests.cpp (lines 1394 - 1395)
<https://reviews.apache.org/r/48054/#comment200788>

    ```c++
    -    JSON::Array frameworks =
    -      state.values["frameworks"].as<JSON::Array>();
    +    JSON::Array frameworks = state.values["frameworks"].as<JSON::Array>();
    ```



src/tests/master_authorization_tests.cpp (lines 1398 - 1399)
<https://reviews.apache.org/r/48054/#comment200789>

    ```c++
    -    JSON::Object framework =
    -      frameworks.values.front().as<JSON::Object>();
    +    JSON::Object framework = frameworks.values.front().as<JSON::Object>();
    ```



src/tests/master_authorization_tests.cpp (lines 1492 - 1494)
<https://reviews.apache.org/r/48054/#comment200790>

    ```c++
    -  Try<Owned<cluster::Slave>> slave = this->StartSlave(
    -      detector.get(),
    -      &containerizer);
    +  Try<Owned<cluster::Slave>> slave =
    +    this->StartSlave(detector.get(), &containerizer);
    ```



src/tests/master_authorization_tests.cpp (line 1510)
<https://reviews.apache.org/r/48054/#comment200791>

    ```c++
    -  Future<vector<Offer> > offers;
    +  Future<vector<Offer>> offers;
    ```



src/tests/master_authorization_tests.cpp (line 1573)
<https://reviews.apache.org/r/48054/#comment200792>

    ```c++
    -    Try<JSON::Object> parse  = JSON::parse<JSON::Object>(response.get().body);
    +    Try<JSON::Object> parse = JSON::parse<JSON::Object>(response.get().body);
    ```


- Michael Park


On May 31, 2016, 10:18 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48054/
> -----------------------------------------------------------
> 
> (Updated May 31, 2016, 10:18 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-5339
>     https://issues.apache.org/jira/browse/MESOS-5339
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added intergration tests for authorization based endpoint filtering.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_authorization_tests.cpp 5c221f059585d49bcccce5848bc0b655adab6b02 
> 
> Diff: https://reviews.apache.org/r/48054/diff/
> 
> 
> Testing
> -------
> 
> make check (OSx)
> + 100x repeat on new tests.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message