mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 48101: Changed the ObjectApprover interface for optional subject and objects.
Date Wed, 01 Jun 2016 01:22:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48101/#review135738
-----------------------------------------------------------



Bad patch!

Reviews applied: [48101, 48092, 48054, 47736, 47704, 47559, 48052, 47558, 46093]

Failed command: ./support/apply-review.sh -n -r 48092

Error:
2016-06-01 01:22:01 URL:https://reviews.apache.org/r/48092/diff/raw/ [1371/1371] -> "48092.patch"
[1]
error: patch failed: CHANGELOG:42
error: CHANGELOG: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13476/console

- Mesos ReviewBot


On June 1, 2016, 12:26 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48101/
> -----------------------------------------------------------
> 
> (Updated June 1, 2016, 12:26 a.m.)
> 
> 
> Review request for mesos, Adam B, Michael Park, Till Toenshoff, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Review 47505  changed the Request.object and subject to become optional
> fields.This patch adapts the ObjectApprover interface to deal with this
>  behavior.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.hpp ea49681c6e47de698dc69b3b273dcd1af1e4400c 
>   src/authorizer/local/authorizer.hpp 9242889fd52cba270c97f51b72c17d6232cbd2b0 
>   src/authorizer/local/authorizer.cpp 5f73f03c927628e0c22b6efc693d02fa4dd50a06 
>   src/master/http.cpp 12453261f73a0410f00287dec7fb3f106fb5cba8 
>   src/tests/mesos.hpp 5d7b5d13ebcf543cd908c33fbfdf541b78869bc7 
>   src/tests/mesos.cpp 6c64bd547413d68de842ee03b13c12bbbf51779c 
> 
> Diff: https://reviews.apache.org/r/48101/diff/
> 
> 
> Testing
> -------
> 
> make check OSx
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message