mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 45999: Ensure GC is terminated last during libprocess shutdown.
Date Thu, 02 Jun 2016 20:30:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45999/
-----------------------------------------------------------

(Updated June 2, 2016, 8:30 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
-------

Rebase.


Bugs: MESOS-5144
    https://issues.apache.org/jira/browse/MESOS-5144


Repository: mesos


Description
-------

Without this change, `finalize()` terminates processes in the order
that they happen to be found when iterating over the `processes`
map. That means that if the GarbageCollector process is terminated
while any GC-managed processes are still running, those processes
will not be GC'd (i.e., they will be leaked).

Fix this by skipping the garbage collector process when iterating
over `processes` in `finalize()`, and then only terminating it after
all other processes have been terminated.


Diffs (updated)
-----

  3rdparty/libprocess/src/process.cpp be120fb85583d438401c24a57dac803be3b5e5d2 

Diff: https://reviews.apache.org/r/45999/diff/


Testing
-------

make check

Confirmed reduction of leaked memory via ASAN on Linux/amd64.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message