mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 44843: Replace NULL with nullptr.
Date Sat, 04 Jun 2016 19:14:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/#review136178
-----------------------------------------------------------



Could you please split this up into `clang-tidy` and `sed`?

This only touches mesos, not libprocess and stout. Is that correct?

Are https://reviews.apache.org/r/45482/ and https://reviews.apache.org/r/45480/ meant to be
discarded now?

- Michael Park


On June 4, 2016, 12:59 p.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44843/
> -----------------------------------------------------------
> 
> (Updated June 4, 2016, 12:59 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
>     https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> RUN: find . -name "*.[hc]pp" | xargs -P 4 sed -i 's/\bNULL\b/nullptr/g'
> 
> 
> Diffs
> -----
> 
>   src/authentication/cram_md5/authenticatee.cpp 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8

>   src/authentication/cram_md5/authenticator.cpp 027eba4f433fff328d68c41005bc59c41c7ae668

>   src/authentication/cram_md5/auxprop.cpp d82d2d2f7793859772d89cc91bee09240624c613 
>   src/authorizer/local/authorizer.cpp 32346bbaf75dce0cbe1676ba515aa8455bfdc54c 
>   src/examples/balloon_executor.cpp 108ebd9afec5b2d592ffbe5c150a9271f1899f2c 
>   src/examples/example_module_impl.cpp aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
>   src/examples/load_generator_framework.cpp 5fac65fd4ab60144da4e06ae080a168a835b9ac0

>   src/examples/test_allocator_module.cpp 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/examples/test_anonymous_module.cpp dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/examples/test_authorizer_module.cpp 19ec7cd114562f74c660b83b39235127d25001ee 
>   src/examples/test_container_logger_module.cpp 76dd494fa4c32514ba14b1f4498b588ac9051b4d

>   src/examples/test_hook_module.cpp bc0bcb91eec0e2f666a76565b6cb3bb374f5b373 
>   src/examples/test_http_authenticator_module.cpp 8affdb60ae6336a2be5218c7bd04a4d5efeeb3f4

>   src/examples/test_isolator_module.cpp a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/examples/test_master_contender_module.cpp d50d9d820de8140ada6383e103cac1e651c4c75e

>   src/examples/test_master_detector_module.cpp ff362db679803fc77b029ae4355ebb40e36a097c

>   src/examples/test_qos_controller_module.cpp f382fc443fa0a4545ba78dc28016e4d0a0dd16b1

>   src/examples/test_resource_estimator_module.cpp 229b2931e9129c194850f04051060d33bfa06570

>   src/exec/exec.cpp 666b1f47cf2d00bd3d80287cfe0221b3c834af86 
>   src/files/files.hpp a41c203349bac0f12ef574fceb201dd08dd957fc 
>   src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
>   src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
>   src/java/jni/org_apache_mesos_Log.cpp 341df13349d56d3c416107e8889ef543b6371eb0 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 9a92ade5d54bd814353acb40170d7aa4d8fe4a77

>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4

>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 728e93523e2bc9adb06bb62c4491ac3a29712961

>   src/java/jni/org_apache_mesos_state_Variable.cpp 5a3805fef57e429b9cb105ba704d1af69b25b4d4

>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 5cce558b42f396aa4e99f750bab38d556bda9196

>   src/jvm/jvm.hpp d5023e4050d109ca97cedb05f85e1c24202ac3b0 
>   src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
>   src/jvm/org/apache/zookeeper.hpp 7e9c3aaa9f0eed44994004f9e32ce7ce3cf6d335 
>   src/launcher/executor.cpp e4c3b75b647b54ffecedfdfa34fb3925f686c0c7 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
>   src/linux/perf.cpp 2364ab5f277354d037376e0cec36fd7138a9e7fa 
>   src/linux/routing/diagnosis/diagnosis.cpp 8b86a8864c08b078425dcc242d323763d6ec15dd

>   src/linux/routing/filter/internal.hpp 8690bf56472c318e85afb53d35494790ae4da27b 
>   src/linux/routing/internal.hpp 8f68119819f7c79ece1a13ac1894b1802ddc8e19 
>   src/linux/routing/link/internal.hpp 8f05e5f513208c8f966bc324c9fe994a5807b051 
>   src/linux/routing/queueing/internal.hpp 768ed325f9b259e150779eb3ad74f4e5d4bcc7a2 
>   src/linux/routing/route.cpp 4b33350dc3761e19121c29c0d090cfdae544e4ef 
>   src/linux/systemd.cpp 9f6e06cfcf6f5b38971ff75eb85326d043140b4b 
>   src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
>   src/local/local.cpp d5dc49f045a1e74ed7b97f90330bec7eab81b382 
>   src/log/leveldb.cpp ba2f62bc97e4a0eaa8a54824551686467db4b9e4 
>   src/log/log.cpp a52b35c5c79ccd80dcce3e5f01656081972423fb 
>   src/log/tool/benchmark.hpp 3051b6ff025252d2c770b0a70d6a66f4f34d7e69 
>   src/log/tool/benchmark.cpp 7e1350675bdfe6c44e86b082bc01f692cc72b850 
>   src/log/tool/initialize.hpp 99c80061442c6379978f907c80a7e9d54a015f04 
>   src/log/tool/initialize.cpp e980772c29ead115fa5da836792281d4336d857f 
>   src/log/tool/read.hpp 937ae8f15f5e2227247ab43aa24c887c13c3cf2c 
>   src/log/tool/read.cpp 415038dfce36ef40f1388af98fcb923da2bbc59a 
>   src/log/tool/replica.hpp c25bb09abc4391614c7a35b9ca91d678a745ffdd 
>   src/log/tool/replica.cpp 11aef65dc71a51b3e38afe6a31de2944f3799711 
>   src/logging/logging.cpp 7ea189950bc3c5b0bb0a31f761ad24ab6e076a77 
>   src/master/allocator/mesos/hierarchical.hpp 3f5dff72945bf81fda4e5bc9b11edfba40cced9d

>   src/master/contender/standalone.hpp 256a4bc184e8c2d9eb556dc606f0ce2dc547bec8 
>   src/master/contender/standalone.cpp 5db792fe9efa31877dc2da9a965b333ab7222858 
>   src/master/contender/zookeeper.cpp 6c9305c0a6c0611927f7cf6306fe9c36c7675045 
>   src/master/http.cpp 824c6e5adcebc83d1ec742c9bd036a8f24c9a343 
>   src/master/main.cpp 294b35d0b9cd1995419a2265f78315d7722eba95 
>   src/master/master.hpp 846edf37d13b44093832ca3d184426b403174b35 
>   src/master/master.cpp 36e12c4bc88ace8aa7e13cef1c0a330aba0a7863 
>   src/master/validation.cpp 309fbed81c9ff0ccc4ff4ee3ee70cf8f1fb2ac55 
>   src/module/manager.hpp 4a9e6a3c4a6b8dbd45073de07610f275ae081ee6 
>   src/module/manager.cpp 725f085a316327918975682cc8b08ba5f43df468 
>   src/python/executor/src/mesos/executor/mesos_executor_driver_impl.cpp f2477d3d46a911423c338913e6f62532d19c72cf

>   src/python/executor/src/mesos/executor/module.cpp f8c63821db616475b95c3d1687893c251fa2daca

>   src/python/executor/src/mesos/executor/proxy_executor.cpp b9c8a2d131e5aadf6fa79af023bb34ae5a3cebba

>   src/python/native_common/common.hpp 166adb32978260750898537e8f45e4f3bbd19c79 
>   src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp e1c91fe00c6548ee3087ea0b814ca600f1e5888b

>   src/python/scheduler/src/mesos/scheduler/module.cpp 62eaf3166c4ebef42665358e8da438b2e3afba20

>   src/python/scheduler/src/mesos/scheduler/proxy_scheduler.cpp 3d8f3bfc9cbff761822580310432177d00450f51

>   src/sched/sched.cpp 9f0c51d52e24505930dfa6500e792da096ffada8 
>   src/scheduler/scheduler.cpp b66661b77f1009c57184f80e285a3b936038c40d 
>   src/slave/container_logger.cpp 85b8c1d3a42baba14741996d791926816b252742 
>   src/slave/container_loggers/lib_logrotate.cpp 89d2bd01dcbddbaf52c3d1cb8bf19bc41566a44b

>   src/slave/container_loggers/logrotate.cpp 08abea9450997df05c2b87b6773f4b7e050d6689

>   src/slave/containerizer/docker.cpp 7453e52082f579c063b53194c07a791c4e471fbb 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 0b406278808a15f3ea549839cc94f56909fa3571

>   src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 368fac7b2e7cff24210b29c6f0769baeea983fbe

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp b9fcde44206f182ffff9ebad96dffd53609e2671

>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 15fff94de6998897ff8fc2d74ceb3fdbc1493445

>   src/slave/containerizer/mesos/launch.cpp 636921c84588be956e1eb806e9a0873ad8e142b9 
>   src/slave/containerizer/mesos/mount.cpp bf17b015e45579882fd31248e8609eec6d58a9da 
>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp ea7829bdacc0da4356f0abd770bb645e1702b55e

>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 86abf2809c592bee536548527ee5bb6d98eeb3ac

>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 7540be6d8a412eb3d380d315c59223236d3eff67

>   src/slave/http.cpp b50775dd88e4bee32a697842f7db47a9923d8524 
>   src/slave/posix_signalhandler.hpp 89ab29bd9c4bdf4f9e0556ab684d0d4ce809100a 
>   src/slave/qos_controllers/load.cpp 234ae1a2215ec835b0bd1ab2bb601d28fd55a728 
>   src/slave/qos_controllers/noop.cpp dc40f43e89212b77611522b0794c675a5ea1c53e 
>   src/slave/resource_estimators/fixed.cpp c858a48bc137185d1e1e24a20f6b75b0dd7912ff 
>   src/slave/resource_estimators/noop.cpp 66c646def36c1050b01d55f9fe6561ca5eed6148 
>   src/slave/slave.cpp c235c14814c320b4a8af8bf839ecced969de6e35 
>   src/slave/status_update_manager.cpp f3b47672c3de87ea5f91bf1568e4c7d223c603db 
>   src/slave/windows_ctrlhandler.hpp e36a1f42a21413051bdae634e5d84f8acbaf7e49 
>   src/state/leveldb.cpp 60c18dd46a489e024e2b96be9739187eeaf8a282 
>   src/state/zookeeper.cpp 1596637faabbce99a1e8b699b684a9c4ad722940 
>   src/tests/containerizer/cgroups_tests.cpp 4cb3d6103ca1120a35aea4714ed3bb9662ed0410

>   src/tests/containerizer/memory_test_helper.cpp a8fdc1919c8c4fb2a9b6bb1cc2630669335e93c0

>   src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9

>   src/tests/environment.cpp 011451b6dd463c83adb98c800e3b777c01fc6826 
>   src/tests/group_tests.cpp 83fca117f687386509b63c7b43c1c8345ba9611c 
>   src/tests/master_contender_detector_tests.cpp ef4786f92f7d48cdd1cdaca7e2167a4113d6a5a9

>   src/tests/mesos.hpp 259c24d2bc4e1cd2a41b0510d9013858c0f8108f 
>   src/tests/mesos.cpp 51d223abb37c16c301d842f36957544540903090 
>   src/tests/module_tests.cpp 54a22e32681fb29b80181c55c7ae6369d2763887 
>   src/tests/registrar_tests.cpp f707a04f03dd33f71071b4f2b45f86529cf65fff 
>   src/tests/script.cpp ec5f2c3016a6081031c1bd6c9bf35a2d6d953700 
>   src/tests/slave_tests.cpp ab4633abf47f068032ee1d4a9b3cdd5428352c0a 
>   src/tests/state_tests.cpp e9f6e850373b0ba16bd84745926efb0e35574f97 
>   src/tests/zookeeper.hpp 2a4e829808a06f1439cc377a6e56169eb129f21f 
>   src/tests/zookeeper_test_server.cpp c4fd4472a03be91274d04186160c123dc5236571 
>   src/tests/zookeeper_tests.cpp 0a360c6a12133e9208638db64e12b27a5328a9d2 
>   src/zookeeper/group.cpp 01680899778e554af70b176db82498ca92b51b60 
>   src/zookeeper/zookeeper.cpp 5b136bbc294be83730235e342bda788035b00d59 
> 
> Diff: https://reviews.apache.org/r/44843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message