mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomasz Janiszewski <jani...@gmail.com>
Subject Re: Review Request 48254: Replaced `NULL` with `nullptr` in stout.
Date Sun, 05 Jun 2016 06:14:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48254/#review136205
-----------------------------------------------------------


Ship it!




Ship It!

- Tomasz Janiszewski


On June 5, 2016, 1:01 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48254/
> -----------------------------------------------------------
> 
> (Updated June 5, 2016, 1:01 a.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski and Neil Conway.
> 
> 
> Bugs: MESOS-3243
>     https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/abort.hpp 490e2ba04a3350a80af6426ea6961a9ae1267e0f 
>   3rdparty/stout/include/stout/elf.hpp e1f0b611e77062b095c1b53ca7ca882d8b0dc892 
>   3rdparty/stout/include/stout/flags/flags.hpp 0935eaff6b902a39353572348c7173a3e515ddaa

>   3rdparty/stout/include/stout/internal/windows/dirent.hpp c1113e52fcd1f438aeceea03c4a67677bf840069

>   3rdparty/stout/include/stout/internal/windows/grp.hpp 232588c46c8207c6a002f60d00aa675f9e505083

>   3rdparty/stout/include/stout/internal/windows/pwd.hpp 46e3ec25cbf379fb2b82297849216b0866baf333

>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 85eb0be4bb3174b3ad48e1ce67be92e7340cf3ad

>   3rdparty/stout/include/stout/ip.hpp ffeb2d721149f600f552021c127694183f1aa837 
>   3rdparty/stout/include/stout/json.hpp a1740a99c37fb364b0230a94e61b9b3b47fc7cf6 
>   3rdparty/stout/include/stout/mac.hpp 09c0d4905ed548d9c82ab6e9083108a3abc0e2aa 
>   3rdparty/stout/include/stout/net.hpp 341d8ecea6f7e1244ad0027f110d6b0c69137667 
>   3rdparty/stout/include/stout/os/environment.hpp 9b4c74d1a7a9ac89db6c6129b11a58d6e0bb207b

>   3rdparty/stout/include/stout/os/freebsd.hpp ce4e4ccd1340e2cff18f5d1b6a9236809bdc69f1

>   3rdparty/stout/include/stout/os/ls.hpp 216a4fc06700f669c757f660e8bc61aadc3dbd35 
>   3rdparty/stout/include/stout/os/osx.hpp a8010925c15fccc9bcd7c5d150ccdd9c98b8bb47 
>   3rdparty/stout/include/stout/os/posix/chown.hpp 6068409fd242f8b7d75fa460c7a49377a8fc321b

>   3rdparty/stout/include/stout/os/posix/fork.hpp a906e4e03aac9ec9d95de62f905dcdbbba27c172

>   3rdparty/stout/include/stout/os/posix/mkdtemp.hpp bbfbb8a07e9d59f3a22e6917e7f247a797f45de8

>   3rdparty/stout/include/stout/os/posix/rmdir.hpp a6d3b578762d5c570542b0497578c330820b821a

>   3rdparty/stout/include/stout/os/posix/sendfile.hpp c2806fa287c607de8f433403b0c224f89385b1a9

>   3rdparty/stout/include/stout/os/posix/shell.hpp b786d47f993bc607e8015aba1a1efda2c73e3bd9

>   3rdparty/stout/include/stout/os/posix/signals.hpp f46f5910f34de534413d4c7df2681baee7c9d348

>   3rdparty/stout/include/stout/os/posix/su.hpp 43e91d6baca9b5e0bb7d6661c4d8002b07d22452

>   3rdparty/stout/include/stout/os/read.hpp 77ad34a16d49e0a7c3561af897339ca3d282dc23 
>   3rdparty/stout/include/stout/os/realpath.hpp c36830972e0425194bf430320db6570852eb0323

>   3rdparty/stout/include/stout/os/sysctl.hpp bb78bb6ea27bd4f2e1035a5764bdeea784f92840

>   3rdparty/stout/include/stout/os/utime.hpp 0d721a1bd5f4ab6a2f17f22c1f3b7d78e9846be1

>   3rdparty/stout/include/stout/os/windows/exists.hpp 6530869ab292e0a129d4b43ae6f19332363d9e14

>   3rdparty/stout/include/stout/os/windows/fcntl.hpp 63533ab4bb5c439b9921bc4476bf13e3baa16ef4

>   3rdparty/stout/include/stout/os/windows/kill.hpp 660c872ae0a2fabf54f6287e7d9f528123a697aa

>   3rdparty/stout/include/stout/os/windows/sendfile.hpp 7b2a72412b31894923d6a4965bfbaf767e269847

>   3rdparty/stout/include/stout/os/windows/shell.hpp 66f230675917500e8a8553c7d1e93c7e2de4095e

>   3rdparty/stout/include/stout/posix/dynamiclibrary.hpp 427ff8a2699a27a48ba1727c1420a01230c04a37

>   3rdparty/stout/include/stout/posix/os.hpp a92da6f755c2c53a1f6ab382a43425b64f9113e2

>   3rdparty/stout/include/stout/protobuf.hpp 3c586ce87f474d246f1e46241aa1d9081bd10998

>   3rdparty/stout/include/stout/svn.hpp 5aeee13db4fa692d429626cb604ef879978ffc93 
>   3rdparty/stout/include/stout/uuid.hpp e3cf21ff986112694a417981c22009323cb23987 
>   3rdparty/stout/include/stout/windows/dynamiclibrary.hpp 4235cb139f7797de8b616213a7a07972216aad35

>   3rdparty/stout/include/stout/windows/error.hpp d634491b301632ce6468f86d04f21fa25afbbaaa

>   3rdparty/stout/include/stout/windows/os.hpp 53bfd81fb3df6baf31599c443776b9b5e4835e1d

>   3rdparty/stout/tests/flags_tests.cpp d491d096f24a2226a8d0df8387798803acf8ba9a 
>   3rdparty/stout/tests/os/filesystem_tests.cpp 2e215385fb702e486cc28050dbf6059b8cf19edf

>   3rdparty/stout/tests/os/process_tests.cpp c945923d7a27d775bd5c48c127adb421a3828103

>   3rdparty/stout/tests/os/strerror_tests.cpp 9846682513a4b7dac5962ea9e866aef416bfcfb2

>   3rdparty/stout/tests/os_tests.cpp 92717639461e7552dc202a0156e015277fd64464 
> 
> Diff: https://reviews.apache.org/r/48254/diff/
> 
> 
> Testing
> -------
> 
> Manual eye test + `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message