mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 48244: Removed support for parsing the filesystem table (fstab).
Date Sun, 05 Jun 2016 13:02:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48244/
-----------------------------------------------------------

(Updated June 5, 2016, 1:02 p.m.)


Review request for mesos and Till Toenshoff.


Changes
-------

Rebase.


Bugs: MESOS-5540
    https://issues.apache.org/jira/browse/MESOS-5540


Repository: mesos


Description (updated)
-------

This functionality relied on the `getfsent` family of functions,
which are not portable (e.g., they are not implemented by musl).
Because we don't actually use this functionality in Mesos,
it seems easiest to remove this code.


Diffs (updated)
-----

  src/linux/fs.hpp 0359e28617fec90d38567b3fe79ae980ad79edac 
  src/linux/fs.cpp cb8295ee620bb717fe148d1c7da54bf0b53a49c7 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  support/docker_build.sh 058b982d1a9ab5ac624d023fb1a1054128157083 

Diff: https://reviews.apache.org/r/48244/diff/


Testing
-------

Successful compilation with Alpine Linux 3.3.3; also tested that the build continues to work
on OSX and various supported Linux distributions (CentOS, Fedora, Debian, Ubuntu).


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message