mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 48240: Added /dev/fd to the list of symlinks created by filesystem/linux.
Date Mon, 06 Jun 2016 06:26:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48240/#review136226
-----------------------------------------------------------


Ship it!




Note that this also conforms to: https://github.com/opencontainers/runtime-spec/blob/master/runtime-linux.md


src/linux/fs.cpp (line 580)
<https://reviews.apache.org/r/48240/#comment201258>

    I would order the list alphabetically (this being the 1st entry) but I can reorder it
when comitting so no worries.


- Jiang Yan Xu


On June 3, 2016, 7:25 p.m., Silas Snider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48240/
> -----------------------------------------------------------
> 
> (Updated June 3, 2016, 7:25 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5543
>     https://issues.apache.org/jira/browse/MESOS-5543
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is necessary to enable bash subshell redirection within the
> container.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
> 
> Diff: https://reviews.apache.org/r/48240/diff/
> 
> 
> Testing
> -------
> 
> I ran a task using the filesystem/linux isolator, that used bash subshell redirection
(i.e., `grep -q -E 'something' <(tail -q -c +0 -f somefile)`. Without this line, the task
fails. With it, it runs just fine.
> 
> 
> Thanks,
> 
> Silas Snider
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message