mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 46158: Completed implementation of the cgroups unified isolator.
Date Mon, 06 Jun 2016 14:15:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46158/#review136250
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 79 - 80)
<https://reviews.apache.org/r/46158/#comment201273>

    So we create subsystem for each container, suppose `"--isolation=cgroups/mem"` and there
are 100 containers created in an agent, we will create 100 `MemorySubsystem` objects, right?
It is a bit overhead since the only differences between these 100 objects are just `"containerId"`
and `"cgroup"`. Can we only create one subsystem object for each enabled subystem specified
in `"--isolation"` and reuse it for all the containers?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 159 - 164)
<https://reviews.apache.org/r/46158/#comment201275>

    I would suggest to merge them into:
    ```
    return cgroups::prepare(
        rootHierarchy,
        cgroupName.get(),
        rootCgroup);
    ```


- Qian Zhang


On April 16, 2016, 6:14 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46158/
> -----------------------------------------------------------
> 
> (Updated April 16, 2016, 6:14 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-5041
>     https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Completed implementation of the cgroups unified isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46158/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message