mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48264: Added test for optional request.object field.
Date Mon, 06 Jun 2016 14:47:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48264/#review136259
-----------------------------------------------------------




src/tests/authorization_tests.cpp (line 2106)
<https://reviews.apache.org/r/48264/#comment201282>

    what do you mean by "is only allowed for `ANY`"?
    
    did you mean "matches an ACL whose Object is `ANY`" ?



src/tests/authorization_tests.cpp (line 2121)
<https://reviews.apache.org/r/48264/#comment201281>

    s/principle/principal/


- Vinod Kone


On June 6, 2016, 8:19 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48264/
> -----------------------------------------------------------
> 
> (Updated June 6, 2016, 8:19 a.m.)
> 
> 
> Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-5405
>     https://issues.apache.org/jira/browse/MESOS-5405
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As MESOS-5405 changes the request.object
> field to optional. We need to check that it only
> matches an `ANY` ACL.
> 
> 
> Diffs
> -----
> 
>   src/tests/authorization_tests.cpp 9e0f0b4f01ae6e466f6d44433a83edcebba4167a 
> 
> Diff: https://reviews.apache.org/r/48264/diff/
> 
> 
> Testing
> -------
> 
> make check (OSX) + repeat new test 100 times
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message