> On May 23, 2016, 5:09 p.m., Adam B wrote:
> > src/Makefile.am, lines 1937-1938
> > <https://reviews.apache.org/r/47374/diff/3/?file=1384789#file1384789line1937>
> >
> > Why does libmesos_tests_la_SOURCES need to include qos_controllers code?
>
> Joseph Wu wrote:
> I don't remember the exact reason, but one of my previous iterations (not published)
broke on this module. It's unnecessary for the current implementation.
I looked it up. LoadQoSController isn't used by Mesos (by default), since only the NoopQoSController
is referenced in non-test code (as a default). Both are included in oversubscription_tests.cpp
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47374/#review134476
-----------------------------------------------------------
On June 10, 2016, 5:03 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47374/
> -----------------------------------------------------------
>
> (Updated June 10, 2016, 5:03 p.m.)
>
>
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, Kapil Arya, Jan Schlicht,
and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This gives external projects easier access to the test helpers used in
> mesos tests.
>
> For example, a module writer may want to write a test like
> `src/tests/oversubscription_tests.cpp`. To build and link against
> this library, the module writer would mimic the build flags for tests:
> ```
> # Main test file is taken directly from Mesos.
> my_module_tests_SOURCES = \
> $(MESOS)/src/tests/main.cpp
>
> my_module_tests_CPPFLAGS = \
> -I$(GMOCK)/include \
> -I$(GTEST)/include \
> -I$(MESOS)/include/mesos \
> -I$(ZOOKEEPER)/include \
> -I$(ZOOKEEPER)/generated \
> $(AM_CPPFLAGS)
>
> my_module_tests_LDADD = \
> $(MESOS)/3rdparty/.libs/libgmock.la \
> $(MESOS)/src/.libs/libmesos.la \
> $(MESOS)/src/.libs/libmesos_tests.la
> ```
>
>
> Diffs
> -----
>
> src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88
>
> Diff: https://reviews.apache.org/r/47374/diff/
>
>
> Testing
> -------
>
> make check on OSX, CentOS 7, Ubuntu 14
>
>
> Thanks,
>
> Joseph Wu
>
>
|