mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 45952: Implemented support for passing agent default docker config.
Date Sun, 12 Jun 2016 18:59:01 GMT


> On June 12, 2016, 6:08 p.m., Jie Yu wrote:
> > src/uri/fetchers/docker.cpp, lines 647-649
> > <https://reviews.apache.org/r/45952/diff/4/?file=1415411#file1415411line647>
> >
> >     I don't get this part. This is not what you're doing here, right? I think a
request to authorization server will return an 401 and we will  set auth header and send the
request again. Putting the comments here is confusing. I would simply add a TODO here saying
that here we assume the auth is basic, and we simply include the auth header while sending
the request. It'll be ignored if auth is not required.
> 
> Gilbert Song wrote:
>     Step 3 ~ 7 is what I haven't done here.
>     
>     >> I think a request to authorization server will return an 401 and we will
 set auth header and send the request again.
>     The auth server would always return a token, but the token is incorrect (not accessible)
if no auth attached or the basic auth is incorrect. We could only know that once the wrong
token sent to registry and get an 401. Then we will attach basic auth to request another token
again.
>     
>     Yeah, a little confusing here. Just want to make it in detail, otherwise people may
not understand what this TODO exactly is.
> 
> Gilbert Song wrote:
>     Step 3 ~ 7 is what I haven't done here.
>     
>     >> I think a request to authorization server will return an 401 and we will
set auth header and send the request again.
>     
>     The auth server would always return a token, but the token is incorrect (not accessible)
if no auth attached or the basic auth is incorrect. We could only know that once the wrong
token sent to registry and get an 401. Then we will attach basic auth to request another token
again.
>     
>     >> Putting the comments here is confusing.
>     
>     Yeah, a little confusing here. Just want to make it in detail, otherwise people may
not understand what this TODO exactly is.

Regarding using an incorrect toke, are you sure? I want to confirm this. It sounds unintuitive
to me.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45952/#review137183
-----------------------------------------------------------


On June 11, 2016, 12:42 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45952/
> -----------------------------------------------------------
> 
> (Updated June 11, 2016, 12:42 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4938
>     https://issues.apache.org/jira/browse/MESOS-4938
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented support for passing agent default docker config.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp cd5849bb9cdd12f2240885a0eae90569d2a9502e

>   src/uri/fetchers/docker.hpp c855a2b55a07bb398f7547b44a85b8ba2d2b2ec3 
>   src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24 
> 
> Diff: https://reviews.apache.org/r/45952/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Tested with mesos-execute, using a private repo from docker hub. Both cases are tested:
> 1. --docker_registry=private_registry
> 2. private_registry/repo
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message