mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 48604: Implemented docker spec helper to parse URL.
Date Mon, 13 Jun 2016 03:25:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48604/#review137218
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/docker/spec.hpp (line 83)
<https://reviews.apache.org/r/48604/#comment202386>

    I would rename this to parseAuthConfig as well. Can you followup with a patch to do the
renaming?



include/mesos/docker/spec.hpp (line 89)
<https://reviews.apache.org/r/48604/#comment202385>

    parseUrl sounds too general.
    
    s/parseUrl/parseAuthUrl/


- Jie Yu


On June 12, 2016, 7:07 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48604/
> -----------------------------------------------------------
> 
> (Updated June 12, 2016, 7:07 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4938
>     https://issues.apache.org/jira/browse/MESOS-4938
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented docker spec helper to parse URL.
> 
> 
> Diffs
> -----
> 
>   include/mesos/docker/spec.hpp b37c7731590ec144df720d7b28eeed5db76f750e 
>   src/docker/spec.cpp 7270d182b8c3a5d5c34cbda2bd736ba489089720 
> 
> Diff: https://reviews.apache.org/r/48604/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message