mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yanyan Hu <yanya...@cn.ibm.com>
Subject Re: Review Request 48593: Refactor Ranges Subtraction.
Date Mon, 13 Jun 2016 04:09:35 GMT


> On June 12, 2016, 9:32 a.m., Guangya Liu wrote:
> > Hi Yanyan, can you please add some test cases for your code chage? You can refer
to https://github.com/apache/mesos/blob/master/src/tests/values_tests.cpp for detail.
> > 
> > You can take a look at https://github.com/apache/mesos/blob/master/docs/newbie-guide.md#making-changes
for how to run a specified unit test case.

Thanks, Guangya, will add some test cases for this change.


- Yanyan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48593/#review137160
-----------------------------------------------------------


On June 12, 2016, 8:03 a.m., Yanyan Hu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48593/
> -----------------------------------------------------------
> 
> (Updated June 12, 2016, 8:03 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-5425
>     https://issues.apache.org/jira/browse/MESOS-5425
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch reimplement Ranges subtraction using
> IntervalSet data type: Ranges values will be
> converted to IntervalSet values for subtraction
> and the result will be converted back to Ranges
> after subtraction is done. This change is for
> fixing jira MESOS-5425.
> 
> 
> Diffs
> -----
> 
>   src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b 
> 
> Diff: https://reviews.apache.org/r/48593/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yanyan Hu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message