mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 48612: Removed conditional for of setting `--prefix=/`.
Date Mon, 13 Jun 2016 07:25:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48612/#review137238
-----------------------------------------------------------



Patch looks great!

Reviews applied: [48594, 48612]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On June 13, 2016, 5:15 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48612/
> -----------------------------------------------------------
> 
> (Updated June 13, 2016, 5:15 a.m.)
> 
> 
> Review request for mesos and Kapil Arya.
> 
> 
> Bugs: MESOS-5577
>     https://issues.apache.org/jira/browse/MESOS-5577
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For bundled 3rdparty packages the `--prefix` flag should always be set
> to `/`, else the 3rdparty installation path might append the
> $MESOS_INSTALL to the installation path.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am fb4a37d50e751703b4ccddb0e004b58560707067 
> 
> Diff: https://reviews.apache.org/r/48612/diff/
> 
> 
> Testing
> -------
> 
> make and make install
> 
> Bundled zookeeper installation takes place on the following path:
> vagrant@mesos-dev:~/mesosphere/mesos/build/3rdparty$ find ~/mesos_install/ -name "zookeeper*"
> /home/vagrant/mesos_install/lib/mesos/3rdparty/include/zookeeper
> /home/vagrant/mesos_install/lib/mesos/3rdparty/include/zookeeper/zookeeper.h
> /home/vagrant/mesos_install/lib/mesos/3rdparty/include/zookeeper/zookeeper_version.h
> /home/vagrant/mesos_install/lib/mesos/3rdparty/include/zookeeper/zookeeper_log.h
> /home/vagrant/mesos_install/lib/mesos/3rdparty/include/zookeeper/zookeeper.jute.h
> /home/vagrant/mesos_install/include/mesos/zookeeper
> /home/vagrant/mesos_install/include/mesos/zookeeper/zookeeper.hpp
> /home/vagrant/mesos_install/include/mesos/state/zookeeper.hpp
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message